Gwynne Raskind wrote:
gwynne                                   Sat, 28 Nov 2009 19:48:38 +0000

Revision: http://svn.php.net/viewvc?view=revision&revision=291398

Log:
unsetting LIBS and LDFLAGS just makes it impossible to specify LDFLAGS from the 
environment. keeping them doesn't seem to cause any trouble

Changed paths:
    U   php/php-src/branches/PHP_5_3/configure.in

Modified: php/php-src/branches/PHP_5_3/configure.in
===================================================================
--- php/php-src/branches/PHP_5_3/configure.in   2009-11-28 19:31:44 UTC (rev 
291397)
+++ php/php-src/branches/PHP_5_3/configure.in   2009-11-28 19:48:38 UTC (rev 
291398)
@@ -946,7 +946,7 @@
   EXTRA_LIBS="-lcrypt $EXTRA_LIBS -lcrypt"
 fi

-unset LIBS LDFLAGS
+#unset LIBS LDFLAGS

 dnl PEAR
 dnl -------------------------------------------------------------------------
@@ -1029,7 +1029,7 @@
 fi

 ZEND_EXTRA_LIBS="$LIBS"
-unset LIBS LDFLAGS
+#unset LIBS LDFLAGS

 PHP_HELP_SEPARATOR([TSRM:])
 PHP_CONFIGURE_PART(Configuring TSRM)
@@ -1041,7 +1041,7 @@
 EXTRA_LDFLAGS="$EXTRA_LDFLAGS $LDFLAGS"
 EXTRA_LDFLAGS_PROGRAM="$EXTRA_LDFLAGS_PROGRAM $LDFLAGS"
 EXTRA_LIBS="$EXTRA_LIBS $LIBS"
-unset LIBS LDFLAGS
+#unset LIBS LDFLAGS

Read 3 lines above this where LDFLAGS is preserved.
Did you test all the thousands of configure option possibilities and also on every single OS we support that this change is ok?

And why are you doing this in PHP_5_3 and not in HEAD? Are you mad?

--Jani




--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Reply via email to