Pierre,
Pierre Joye wrote:
On Thu, Dec 3, 2009 at 11:49 AM, Andrey Hristov <p...@hristov.com> wrote:
Pierre,
_please_, don't touch what you don't fully understand, right?
Advertising
As it affects badly our testing ability, I will have to touch it again
if necessary.
Where can the results of this testing be seen?
I have been explained this exact problem in the past already, and
reverting my commit is really not the right thing to do as it
introduces again the error. The easiest way to avoid that is to
actually fix the error instead of reintroduce it again and again.
Your commit has right syntax but is semantically wrong. These lines of
code are currently not covered by tests, thus you did not see that the
new code was incorrect and leading to crashes. When you see I commit the
same thing again, I might have a reason, and then just don't freak out
by disabling code with ifdef which makes the other part of the source
that uses it wrong.
Thanks for your work.
Cheers,
Best,
Andrey
--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
