johannes                                 Thu, 11 Feb 2010 22:14:06 +0000

Revision: http://svn.php.net/viewvc?view=revision&revision=294903

Log:
Revert 290786: Fixed bug #49521 (PDO fetchObject sets values before calling
constructor)

Bug: http://bugs.php.net/49521 (Closed) PDO fetchObject sets values before 
calling constructor
      
Changed paths:
    U   php/php-src/branches/PHP_5_3/ext/pdo/pdo_stmt.c
    U   php/php-src/branches/PHP_5_3/ext/pdo/tests/pdo_005.phpt
    U   
php/php-src/branches/PHP_5_3/ext/pdo_mysql/tests/pdo_mysql_stmt_fetchobject.phpt
    D   php/php-src/branches/PHP_5_3/ext/pdo_sqlite/tests/bug49521.phpt
    U   php/php-src/trunk/ext/pdo/pdo_stmt.c
    U   php/php-src/trunk/ext/pdo/tests/pdo_005.phpt
    U   php/php-src/trunk/ext/pdo_mysql/tests/pdo_mysql_stmt_fetchobject.phpt
    D   php/php-src/trunk/ext/pdo_sqlite/tests/bug49521.phpt

Modified: php/php-src/branches/PHP_5_3/ext/pdo/pdo_stmt.c
===================================================================
--- php/php-src/branches/PHP_5_3/ext/pdo/pdo_stmt.c	2010-02-11 22:13:22 UTC (rev 294902)
+++ php/php-src/branches/PHP_5_3/ext/pdo/pdo_stmt.c	2010-02-11 22:14:06 UTC (rev 294903)
@@ -1034,32 +1034,6 @@
 			}
 		}

-		switch (how) {
-			case PDO_FETCH_CLASS:
-				if (ce->constructor && !(flags & (PDO_FETCH_PROPS_LATE | PDO_FETCH_SERIALIZE))) {
-					stmt->fetch.cls.fci.object_ptr = return_value;
-					stmt->fetch.cls.fcc.object_ptr = return_value;
-					if (zend_call_function(&stmt->fetch.cls.fci, &stmt->fetch.cls.fcc TSRMLS_CC) == FAILURE) {
-						pdo_raise_impl_error(stmt->dbh, stmt, "HY000", "could not call class constructor" TSRMLS_CC);
-						return 0;
-					} else {
-						if (stmt->fetch.cls.retval_ptr) {
-							zval_ptr_dtor(&stmt->fetch.cls.retval_ptr);
-						}
-					}
-				}
-				if (flags & PDO_FETCH_CLASSTYPE) {
-					do_fetch_opt_finish(stmt, 0 TSRMLS_CC);
-					stmt->fetch.cls.ce = old_ce;
-					stmt->fetch.cls.ctor_args = old_ctor_args;
-					stmt->fetch.cls.fci.param_count = old_arg_count;
-				}
-				break;
-
-			default:
-				break;
-		}
-
 		for (idx = 0; i < stmt->column_count; i++, idx++) {
 			zval *val;
 			MAKE_STD_ZVAL(val);
@@ -1193,6 +1167,27 @@
 		}

 		switch (how) {
+			case PDO_FETCH_CLASS:
+				if (ce->constructor && !(flags & (PDO_FETCH_PROPS_LATE | PDO_FETCH_SERIALIZE))) {
+					stmt->fetch.cls.fci.object_ptr = return_value;
+					stmt->fetch.cls.fcc.object_ptr = return_value;
+					if (zend_call_function(&stmt->fetch.cls.fci, &stmt->fetch.cls.fcc TSRMLS_CC) == FAILURE) {
+						pdo_raise_impl_error(stmt->dbh, stmt, "HY000", "could not call class constructor" TSRMLS_CC);
+						return 0;
+					} else {
+						if (stmt->fetch.cls.retval_ptr) {
+							zval_ptr_dtor(&stmt->fetch.cls.retval_ptr);
+						}
+					}
+				}
+				if (flags & PDO_FETCH_CLASSTYPE) {
+					do_fetch_opt_finish(stmt, 0 TSRMLS_CC);
+					stmt->fetch.cls.ce = old_ce;
+					stmt->fetch.cls.ctor_args = old_ctor_args;
+					stmt->fetch.cls.fci.param_count = old_arg_count;
+				}
+				break;
+
 			case PDO_FETCH_FUNC:
 				stmt->fetch.func.fci.param_count = idx;
 				stmt->fetch.func.fci.retval_ptr_ptr = &retval;

Modified: php/php-src/branches/PHP_5_3/ext/pdo/tests/pdo_005.phpt
===================================================================
--- php/php-src/branches/PHP_5_3/ext/pdo/tests/pdo_005.phpt	2010-02-11 22:13:22 UTC (rev 294902)
+++ php/php-src/branches/PHP_5_3/ext/pdo/tests/pdo_005.phpt	2010-02-11 22:14:06 UTC (rev 294903)
@@ -34,7 +34,7 @@

 	public function __construct(&$row)
 	{
-		echo __METHOD__ . "($row)\n";
+		echo __METHOD__ . "($row,{$this->id})\n";
 		$this->row = $row++;
 	}
 }
@@ -108,9 +108,9 @@
     string(2) "CC"
   }
 }
-TestDerived::__construct(0)
-TestDerived::__construct(1)
-TestDerived::__construct(2)
+TestDerived::__construct(0,1)
+TestDerived::__construct(1,2)
+TestDerived::__construct(2,3)
 array(3) {
   [0]=>
   object(TestDerived)#%d (5) {
@@ -151,4 +151,4 @@
     ["val2"]=>
     string(2) "CC"
   }
-}
+}
\ No newline at end of file

Modified: php/php-src/branches/PHP_5_3/ext/pdo_mysql/tests/pdo_mysql_stmt_fetchobject.phpt
===================================================================
--- php/php-src/branches/PHP_5_3/ext/pdo_mysql/tests/pdo_mysql_stmt_fetchobject.phpt	2010-02-11 22:13:22 UTC (rev 294902)
+++ php/php-src/branches/PHP_5_3/ext/pdo_mysql/tests/pdo_mysql_stmt_fetchobject.phpt	2010-02-11 22:14:06 UTC (rev 294903)
@@ -71,21 +71,21 @@
 MySQLPDOTest::dropTestTable();
 ?>
 --EXPECTF--
-myclass::__construct(0, 1): 0 / 0
 myclass::__set(id, -'1'-) 1
 myclass::__set(, -''-) 2
 myclass::__set(null, -NULL-) 3
 myclass::__set(, -''-) 4
-myclass::__construct(1, 2): 4 / 0
+myclass::__construct(0, 1): 4 / 4
 myclass::__set(id, -'2'-) 1
 myclass::__set(, -''-) 2
 myclass::__set(null, -NULL-) 3
 myclass::__set(, -''-) 4
-myclass::__construct(2, 3): 8 / 0
+myclass::__construct(1, 2): 8 / 4
 myclass::__set(id, -'3'-) 1
 myclass::__set(, -''-) 2
 myclass::__set(null, -NULL-) 3
 myclass::__set(, -''-) 4
+myclass::__construct(2, 3): 12 / 4
 object(myclass)#%d (4) {
   [%u|b%"set_calls":"myclass":private]=>
   int(4)
@@ -96,4 +96,4 @@
   [%u|b%"null"]=>
   NULL
 }
-done!
+done!
\ No newline at end of file

Deleted: php/php-src/branches/PHP_5_3/ext/pdo_sqlite/tests/bug49521.phpt
===================================================================
--- php/php-src/branches/PHP_5_3/ext/pdo_sqlite/tests/bug49521.phpt	2010-02-11 22:13:22 UTC (rev 294902)
+++ php/php-src/branches/PHP_5_3/ext/pdo_sqlite/tests/bug49521.phpt	2010-02-11 22:14:06 UTC (rev 294903)
@@ -1,39 +0,0 @@
---TEST--
-Bug #49521 (PDO fetchObject sets values before calling constructor)
---SKIPIF--
-<?php
-if (!extension_loaded('pdo_sqlite')) die ("skip Need PDO_SQlite support");
-?>
---FILE--
-<?php
-
-class Book {
-    public $title = 'test';
-    public $author;
-
-	public function __construct($x) {
-		$this->title = '';
-		echo __METHOD__,"\n";
-	}
-	public function __set($a, $b) {
-		echo __METHOD__,"\n";
-		var_dump($a);
-	}
-}
-
-$pdo = new PDO('sqlite::memory:');
-$pdo->exec('CREATE TABLE book(title,author)');
-$pdo->exec('INSERT INTO book VALUES ("PHP","Rasmus")');
-$statement = $pdo->prepare('SELECT * FROM book WHERE title="PHP"');
-$statement->execute();
-var_dump($statement->fetchObject('Book', array(1)));
-
-?>
---EXPECTF--
-Book::__construct
-object(Book)#%d (2) {
-  [%u|b%"title"]=>
-  string(3) "PHP"
-  [%u|b%"author"]=>
-  string(6) "Rasmus"
-}

Modified: php/php-src/trunk/ext/pdo/pdo_stmt.c
===================================================================
--- php/php-src/trunk/ext/pdo/pdo_stmt.c	2010-02-11 22:13:22 UTC (rev 294902)
+++ php/php-src/trunk/ext/pdo/pdo_stmt.c	2010-02-11 22:14:06 UTC (rev 294903)
@@ -1038,32 +1038,6 @@
 			}
 		}

-		switch (how) {
-			case PDO_FETCH_CLASS:
-				if (ce->constructor && !(flags & (PDO_FETCH_PROPS_LATE | PDO_FETCH_SERIALIZE))) {
-					stmt->fetch.cls.fci.object_ptr = return_value;
-					stmt->fetch.cls.fcc.object_ptr = return_value;
-					if (zend_call_function(&stmt->fetch.cls.fci, &stmt->fetch.cls.fcc TSRMLS_CC) == FAILURE) {
-						pdo_raise_impl_error(stmt->dbh, stmt, "HY000", "could not call class constructor" TSRMLS_CC);
-						return 0;
-					} else {
-						if (stmt->fetch.cls.retval_ptr) {
-							zval_ptr_dtor(&stmt->fetch.cls.retval_ptr);
-						}
-					}
-				}
-				if (flags & PDO_FETCH_CLASSTYPE) {
-					do_fetch_opt_finish(stmt, 0 TSRMLS_CC);
-					stmt->fetch.cls.ce = old_ce;
-					stmt->fetch.cls.ctor_args = old_ctor_args;
-					stmt->fetch.cls.fci.param_count = old_arg_count;
-				}
-				break;
-
-			default:
-				break;
-		}
-
 		for (idx = 0; i < stmt->column_count; i++, idx++) {
 			zval *val;
 			MAKE_STD_ZVAL(val);
@@ -1202,6 +1176,27 @@
 		}

 		switch (how) {
+			case PDO_FETCH_CLASS:
+				if (ce->constructor && !(flags & (PDO_FETCH_PROPS_LATE | PDO_FETCH_SERIALIZE))) {
+					stmt->fetch.cls.fci.object_ptr = return_value;
+					stmt->fetch.cls.fcc.object_ptr = return_value;
+					if (zend_call_function(&stmt->fetch.cls.fci, &stmt->fetch.cls.fcc TSRMLS_CC) == FAILURE) {
+						pdo_raise_impl_error(stmt->dbh, stmt, "HY000", "could not call class constructor" TSRMLS_CC);
+						return 0;
+					} else {
+						if (stmt->fetch.cls.retval_ptr) {
+							zval_ptr_dtor(&stmt->fetch.cls.retval_ptr);
+						}
+					}
+				}
+				if (flags & PDO_FETCH_CLASSTYPE) {
+					do_fetch_opt_finish(stmt, 0 TSRMLS_CC);
+					stmt->fetch.cls.ce = old_ce;
+					stmt->fetch.cls.ctor_args = old_ctor_args;
+					stmt->fetch.cls.fci.param_count = old_arg_count;
+				}
+				break;
+
 			case PDO_FETCH_FUNC:
 				stmt->fetch.func.fci.param_count = idx;
 				stmt->fetch.func.fci.retval_ptr_ptr = &retval;

Modified: php/php-src/trunk/ext/pdo/tests/pdo_005.phpt
===================================================================
--- php/php-src/trunk/ext/pdo/tests/pdo_005.phpt	2010-02-11 22:13:22 UTC (rev 294902)
+++ php/php-src/trunk/ext/pdo/tests/pdo_005.phpt	2010-02-11 22:14:06 UTC (rev 294903)
@@ -34,7 +34,7 @@

 	public function __construct(&$row)
 	{
-		echo __METHOD__ . "($row)\n";
+		echo __METHOD__ . "($row,{$this->id})\n";
 		$this->row = $row++;
 	}
 }
@@ -108,9 +108,9 @@
     unicode(2) "CC"
   }
 }
-TestDerived::__construct(0)
-TestDerived::__construct(1)
-TestDerived::__construct(2)
+TestDerived::__construct(0,1)
+TestDerived::__construct(1,2)
+TestDerived::__construct(2,3)
 array(3) {
   [0]=>
   object(TestDerived)#%d (5) {

Modified: php/php-src/trunk/ext/pdo_mysql/tests/pdo_mysql_stmt_fetchobject.phpt
===================================================================
--- php/php-src/trunk/ext/pdo_mysql/tests/pdo_mysql_stmt_fetchobject.phpt	2010-02-11 22:13:22 UTC (rev 294902)
+++ php/php-src/trunk/ext/pdo_mysql/tests/pdo_mysql_stmt_fetchobject.phpt	2010-02-11 22:14:06 UTC (rev 294903)
@@ -71,21 +71,21 @@
 MySQLPDOTest::dropTestTable();
 ?>
 --EXPECTF--
-myclass::__construct(0, 1): 0 / 0
 myclass::__set(id, -'1'-) 1
 myclass::__set(, -''-) 2
 myclass::__set(null, -NULL-) 3
 myclass::__set(, -''-) 4
-myclass::__construct(1, 2): 4 / 0
+myclass::__construct(0, 1): 4 / 4
 myclass::__set(id, -'2'-) 1
 myclass::__set(, -''-) 2
 myclass::__set(null, -NULL-) 3
 myclass::__set(, -''-) 4
-myclass::__construct(2, 3): 8 / 0
+myclass::__construct(1, 2): 8 / 4
 myclass::__set(id, -'3'-) 1
 myclass::__set(, -''-) 2
 myclass::__set(null, -NULL-) 3
 myclass::__set(, -''-) 4
+myclass::__construct(2, 3): 12 / 4
 object(myclass)#%d (4) {
   [%u|b%"set_calls":"myclass":private]=>
   int(4)
@@ -96,4 +96,4 @@
   [%u|b%"null"]=>
   NULL
 }
-done!
+done!
\ No newline at end of file

Deleted: php/php-src/trunk/ext/pdo_sqlite/tests/bug49521.phpt
===================================================================
--- php/php-src/trunk/ext/pdo_sqlite/tests/bug49521.phpt	2010-02-11 22:13:22 UTC (rev 294902)
+++ php/php-src/trunk/ext/pdo_sqlite/tests/bug49521.phpt	2010-02-11 22:14:06 UTC (rev 294903)
@@ -1,39 +0,0 @@
---TEST--
-Bug #49521 (PDO fetchObject sets values before calling constructor)
---SKIPIF--
-<?php
-if (!extension_loaded('pdo_sqlite')) die ("skip Need PDO_SQlite support");
-?>
---FILE--
-<?php
-
-class Book {
-    public $title = 'test';
-    public $author;
-
-	public function __construct($x) {
-		$this->title = '';
-		echo __METHOD__,"\n";
-	}
-	public function __set($a, $b) {
-		echo __METHOD__,"\n";
-		var_dump($a);
-	}
-}
-
-$pdo = new PDO('sqlite::memory:');
-$pdo->exec('CREATE TABLE book(title,author)');
-$pdo->exec('INSERT INTO book VALUES ("PHP","Rasmus")');
-$statement = $pdo->prepare('SELECT * FROM book WHERE title="PHP"');
-$statement->execute();
-var_dump($statement->fetchObject('Book', array(1)));
-
-?>
---EXPECTF--
-Book::__construct
-object(Book)#%d (2) {
-  [%u|b%"title"]=>
-  string(3) "PHP"
-  [%u|b%"author"]=>
-  string(6) "Rasmus"
-}
-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Reply via email to