we already explained why, blame svn.

Cheers,

On Fri, Feb 19, 2010 at 12:00 PM, Kalle Sommer Nielsen <ka...@php.net> wrote:
> ---------- Forwarded message ----------
> From: Kalle Sommer Nielsen <ka...@php.net>
> Date: 2010/2/9
> Subject: Re: [PHP-CVS] svn: /php/php-src/branches/PHP_5_3_2/
> ext/snmp/config.w32 tests/security/open_basedir_parse_ini_file.phpt
> To: Pierre Joye <paj...@php.net>
>
>
> 2010/2/9 Pierre Joye <paj...@php.net>:
>> +       if (CHECK_HEADER_ADD_INCLUDE("snmp.h", "CFLAGS_SNMP", PHP_PHP_BUILD 
>> + "\\include\\net-snmp;" + PHP_SNMP)) {
>> +               if (CHECK_LIB("netsnmp.lib", "snmp", PHP_SNMP)) {
>> +                       EXTENSION('snmp', 'snmp.c');
>> +                       CHECK_LIB("libeay32.lib", "snmp", PHP_SNMP)
>
> This doesn't look right, the CHECK_LIB call should be in a conditional
> here? no? Also, I don't remember how strict JScript is, but the
> function call is missing a ;, but I remember Douglas Crockford saying
> something about JS and its magic semicolons =]
>
>> +                       AC_DEFINE('HAVE_SNMP', 1);
>> +                       AC_DEFINE("HAVE_NET_SNMP", 1);
>> +               } else if (CHECK_LIB("libsnmp.lib", "snmp", PHP_SNMP)) {
>> +                       EXTENSION('snmp', 'snmp.c');
>> +                       AC_DEFINE('HAVE_SNMP', 1);
>> +               } else {
>> +                       WARNING("snmp not enabled; libraries and headers not 
>> found");
>> +               }
>
> Also, in every commit you do to 5.3.2, you seem to change properties
> on /ext/tidy/tests/ and an open_base_dir test.
>
> --
> regards,
>
> Kalle Sommer Nielsen
> ka...@php.net
>
>
>
> --
> regards,
>
> Kalle Sommer Nielsen
> ka...@php.net
>
> --
> PHP CVS Mailing List (http://www.php.net/)
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>



-- 
Pierre

@pierrejoye | http://blog.thepimp.net | http://www.libgd.org

--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Reply via email to