On 12 March 2010 00:11, Hannes Magnusson <hannes.magnus...@gmail.com> wrote:
> On Thu, Mar 11, 2010 at 07:20, Adam Harvey <ahar...@php.net> wrote:
>> aharvey                                  Thu, 11 Mar 2010 06:20:22 +0000
>>
>> Revision: http://svn.php.net/viewvc?view=revision&revision=296060
>>
>> Log:
>> Fixed bug #51269 (zlib.output_compression Overwrites Vary Header).
>
> Isn't this the same as #40325, which is fixed in HEAD?

Not exactly, although it is closely related. #40325 was about sending
Vary: Accept-Encoding in the general case when the gzip output handler
is being used — this is well and good, but because
sapi_add_header_ex() was being called with the replace flag set, any
other Vary headers (such as the Vary: Cookie example in #51269) were
being obliterated.

The linked revision changes that. The codepath for HEAD is obviously
quite different due to the new output handling code, but it had the
same issue.

Adam

--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Reply via email to