Re: [PHP-CVS] svn: /php/php-src/trunk/ INSTALL NEWS README.input_filter Zend/tests/unset_cv06.phpt ext/filter/filter.c ext/mbstring/mb_gpc.c ext/mbstring/mb_gpc.h ext/mbstring/mbstring.c ext/mbstring/tests/mb_parse_str.phpt ext/mbstring/tests/mb_parse_str02.phpt ext/session/session.c ext/session/tests/001.phpt ext/session/tests/003.phpt ext/session/tests/004.phpt ext/session/tests/005.phpt ext/session/tests/006.phpt ext/session/tests/007.phpt ext/session/tests/008-php4.2.3.phpt ext/session/tests/009.phpt ext/

[Johannes Schlüter]

Hi,

On Wed, 2010-04-21 at 01:27 +0000, Kalle Sommer Nielsen wrote:
> Modified: php/php-src/trunk/ext/session/session.c
> ===================================================================
> --- php/php-src/trunk/ext/session/session.c     2010-04-21 01:18:19
> UTC (rev 298240)
> +++ php/php-src/trunk/ext/session/session.c     2010-04-21 01:27:22
> UTC (rev 298241)
> @@ -131,76 +131,18 @@
[...]
>         IF_SESSION_VARS() {
> -               if (PS(bug_compat) && !PG(register_globals)) {
> +               if (PS(bug_compat)) {
>                         HashTable *ht =
> Z_ARRVAL_P(PS(http_session_vars));
>                         HashPosition pos;
>                         zval **val;
> @@ -564,7 +492,7 @@
>                         }
> 
>                         if (do_warn && PS(bug_compat_warn)) {

I think this compat thing can be completely drop along with r_g.

Additionally: I think one might refactor the serialization logic.
Currently each variable is serialized individually. Might be nicer to
serialize($_SESSION) as one. This breaks the session files, which should
be acceptable, but gives a bit cleaner code.

johannes




-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php