srinatar                                 Wed, 23 Jun 2010 19:06:33 +0000

Revision: http://svn.php.net/viewvc?view=revision&revision=300707

Log:
- Fixed bug #52162 (custom request header variables with numbers are removed)

Bug: http://bugs.php.net/52162 (Assigned) for NSAPI module, custom request 
header variables with numbers are removed
      
Changed paths:
    U   php/php-src/branches/PHP_5_2/NEWS
    U   php/php-src/branches/PHP_5_2/sapi/nsapi/nsapi.c
    U   php/php-src/branches/PHP_5_3/NEWS
    U   php/php-src/branches/PHP_5_3/sapi/nsapi/nsapi.c
    U   php/php-src/trunk/sapi/nsapi/nsapi.c

Modified: php/php-src/branches/PHP_5_2/NEWS
===================================================================
--- php/php-src/branches/PHP_5_2/NEWS   2010-06-23 18:28:26 UTC (rev 300706)
+++ php/php-src/branches/PHP_5_2/NEWS   2010-06-23 19:06:33 UTC (rev 300707)
@@ -1,6 +1,8 @@
 PHP                                                                        NEWS
 |||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
 ?? Jun 2010, PHP 5.2.14
+- Fixed bug #52162 (custom request header variables with numbers are removed).
+  (Sriram Natarajan)
 - Fixed bug #52061 (memory_limit above 2G). (Felipe)
 - Fixed bug #52010 (open_basedir restrictions mismatch on vacuum command).
   (Ilia, Felipe)

Modified: php/php-src/branches/PHP_5_2/sapi/nsapi/nsapi.c
===================================================================
--- php/php-src/branches/PHP_5_2/sapi/nsapi/nsapi.c     2010-06-23 18:28:26 UTC 
(rev 300706)
+++ php/php-src/branches/PHP_5_2/sapi/nsapi/nsapi.c     2010-06-23 19:06:33 UTC 
(rev 300707)
@@ -634,7 +634,7 @@
                                if (value) {
                                        for(p = value + pos; *p; p++) {
                                                *p = toupper(*p);
-                                               if (*p < 'A' || *p > 'Z') {
+                                               if (!isalnum(*p)) {
                                                        *p = '_';
                                                }
                                        }

Modified: php/php-src/branches/PHP_5_3/NEWS
===================================================================
--- php/php-src/branches/PHP_5_3/NEWS   2010-06-23 18:28:26 UTC (rev 300706)
+++ php/php-src/branches/PHP_5_3/NEWS   2010-06-23 19:06:33 UTC (rev 300707)
@@ -3,6 +3,8 @@
 ?? ??? 2010, PHP 5.3.3 RC2
 - Implemented FR #51295 (SQLite3::busyTimeout not existing). (Mark)
 - Fixed the mail.log ini setting when no filename was given. (Johannes)
+- Fixed bug #52162 (custom request header variables with numbers are removed).
+  (Sriram Natarajan)
 - Fixed bug #52115 (mysqli_result::fetch_all returns null, not an empty array).
   (Andrey)


Modified: php/php-src/branches/PHP_5_3/sapi/nsapi/nsapi.c
===================================================================
--- php/php-src/branches/PHP_5_3/sapi/nsapi/nsapi.c     2010-06-23 18:28:26 UTC 
(rev 300706)
+++ php/php-src/branches/PHP_5_3/sapi/nsapi/nsapi.c     2010-06-23 19:06:33 UTC 
(rev 300707)
@@ -687,7 +687,7 @@
                                if (value) {
                                        for(p = value + pos; *p; p++) {
                                                *p = toupper(*p);
-                                               if (*p < 'A' || *p > 'Z') {
+                                               if (!isalnum(*p)) {
                                                        *p = '_';
                                                }
                                        }

Modified: php/php-src/trunk/sapi/nsapi/nsapi.c
===================================================================
--- php/php-src/trunk/sapi/nsapi/nsapi.c        2010-06-23 18:28:26 UTC (rev 
300706)
+++ php/php-src/trunk/sapi/nsapi/nsapi.c        2010-06-23 19:06:33 UTC (rev 
300707)
@@ -684,7 +684,7 @@
                        if (value) {
                                for(p = value + pos; *p; p++) {
                                        *p = toupper(*p);
-                                       if (*p < 'A' || *p > 'Z') {
+                                       if (!isalnum(*p)) {
                                                *p = '_';
                                        }
                                }

-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Reply via email to