Hi Kalle,

Your patch was definitely wrong and I reverted it.

This code reads a terminating FastCGI header which can be omitted.
With your change PHP reads just a single byte instead of whole header, as result FastCGI manager receives SIGPIPE and may assume that it can't deliver request.

I don't know what you tried to fix because on Unix recv() has void* argument.

Thanks. Dmitry.

Kalle Sommer Nielsen wrote:
kalle                                    Sun, 19 Sep 2010 19:18:30 +0000

Revision: http://svn.php.net/viewvc?view=revision&revision=303577

Fix incompatible types, we need to use a char here for recv()

Changed paths:
    U   php/php-src/trunk/sapi/cgi/fastcgi.c

Modified: php/php-src/trunk/sapi/cgi/fastcgi.c
--- php/php-src/trunk/sapi/cgi/fastcgi.c        2010-09-19 19:08:56 UTC (rev 
+++ php/php-src/trunk/sapi/cgi/fastcgi.c        2010-09-19 19:18:30 UTC (rev 
@@ -1108,7 +1108,7 @@
                } else {
                        if (!force) {
-                               fcgi_header buf;
+                               char buf;

                                shutdown(req->fd, 1);
                                /* read the last FCGI_STDIN header (it may be 
omitted) */

PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Reply via email to