I was thinking that this is rather a *big* change, so we'd better roll our patches into one and commit it altogether. I am fine if that works for anyone else.
Regards, Moriyoshi On Thu, Dec 9, 2010 at 6:11 PM, Dmitry Stogov <dmi...@zend.com> wrote: > Hi Moriyoshi, > > Ops, sorry. I didn't understand your disagreement, and I didn't see any > other objections. So I committed the patch as it was planned. Could you > prepare a patch on top of this one? > > I'm also going to look into your recommendation of moving > mbstring.script_encoding into zend.script_encoding instead of > zend.multibyte. > > Thanks. Dmitry. > > On 12/09/2010 09:02 AM, Moriyoshi Koizumi wrote: >> >> Please revert. >> >> On Thu, Dec 9, 2010 at 3:00 PM, Moriyoshi Koizumi<m...@mozo.jp> wrote: >>> >>> Hey, I don't think there was agreement on this yet. I've actually >>> been preparing a patch that minimizes the extra hook points in SAPI. >>> >>> Moriyoshi >>> >>> On Wed, Dec 8, 2010 at 8:27 PM, Dmitry Stogov<dmi...@php.net> wrote: >>>> >>>> dmitry Wed, 08 Dec 2010 11:27:34 +0000 >>>> >>>> Revision: http://svn.php.net/viewvc?view=revision&revision=306077 >>>> >>>> Log: >>>> Removed compile time dependency from ext/mbstring >>>> >>>> Changed paths: >>>> U php/php-src/trunk/NEWS >>>> U php/php-src/trunk/Zend/zend_compile.c >>>> U php/php-src/trunk/Zend/zend_globals.h >>>> U php/php-src/trunk/Zend/zend_multibyte.c >>>> U php/php-src/trunk/Zend/zend_multibyte.h >>>> U php/php-src/trunk/ext/exif/exif.c >>>> U php/php-src/trunk/ext/mbstring/mbstring.c >>>> U php/php-src/trunk/ext/standard/html.c >>>> U php/php-src/trunk/main/rfc1867.c >>>> U php/php-src/trunk/main/rfc1867.h >>>> A php/php-src/trunk/tests/basic/028.phpt >>>> A php/php-src/trunk/tests/basic/029.phpt >>>> >>>> >>>> -- >>>> PHP CVS Mailing List (http://www.php.net/) >>>> To unsubscribe, visit: http://www.php.net/unsub.php >>>> >>> > > -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php