Hi Adam 2011/1/10 Adam Harvey <ahar...@php.net>: > On 8 January 2011 10:34, Rui Hirokawa <hirok...@php.net> wrote: >> hirokawa Sat, 08 Jan 2011 02:34:33 +0000 >> >> Revision: http://svn.php.net/viewvc?view=revision&revision=307248 >> >> Log: >> MFH: added an option to http_build_query for RFC-3986 >> based url-encoding. > > Somebody should double check me on this, because binary > compatibility's not one of my stronger points, but isn't the change to > the php_url_encode_hash_ex() definition going to break BC in 5.3? > ext/standard/php_http.h is one of the headers we install.
It will break the extensions API, because of extensions compiled for 5.3.5 is used with 5.3.6, then they will fail dynamic linking. I had to do the same thing when I merged the copy stream context support for 5.3, what I did was: Added php_copy_stream() which was the implementation of its counterpart php_copy_ex(), so the API was the same, and added a new function. I think the same should be done to achieve BC here. -- regards, Kalle Sommer Nielsen ka...@php.net -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
