Hi, because I think that the tests is at fault here. I checked some other cases, where we validate INI variables(through PHP_INI_MH), and I think that the code is fine. a similar case which generates "double" warning: tyrael@sanctuary:~$ php -n -d error_reporting=-1 -d display_startup_errors=1 -d zlib.output_compression=1 -d output_handler=1 -r '' PHP Fatal error: PHP Startup: Cannot use both zlib.output_compression and output_handler together!! in Unknown on line 0
Fatal error: PHP Startup: Cannot use both zlib.output_compression and output_handler together!! in Unknown on line 0 this happens consistently with all current branches and even with 5.2, so I think that it is the intended behavior. so changing the test to expect this seemed the logical choice. On Sun, Sep 4, 2011 at 6:10 PM, Alexey Shein <con...@gmail.com> wrote: > Hello, why did you fix the test this way? Why not to fix the code and > remove excessive warning? > > 2011/9/4 Ferenc Kovacs <tyr...@php.net>: >> tyrael Sun, 04 Sep 2011 14:28:52 +0000 >> >> Revision: http://svn.php.net/viewvc?view=revision&revision=316109 >> >> Log: >> passing an invalid session.upload_progress.freq always generates an >> additional startup error >> >> Changed paths: >> U >> php/php-src/branches/PHP_5_4/ext/session/tests/rfc1867_invalid_settings.phpt >> U php/php-src/trunk/ext/session/tests/rfc1867_invalid_settings.phpt >> >> Modified: >> php/php-src/branches/PHP_5_4/ext/session/tests/rfc1867_invalid_settings.phpt >> =================================================================== >> --- >> php/php-src/branches/PHP_5_4/ext/session/tests/rfc1867_invalid_settings.phpt >> 2011-09-04 14:21:27 UTC (rev 316108) >> +++ >> php/php-src/branches/PHP_5_4/ext/session/tests/rfc1867_invalid_settings.phpt >> 2011-09-04 14:28:52 UTC (rev 316109) >> @@ -9,5 +9,7 @@ >> var_dump(ini_get("session.upload_progress.freq")); >> ?> >> --EXPECTF-- >> +PHP Warning: PHP Startup: session.upload_progress.freq must be greater >> than or equal to zero in %s >> + >> Warning: PHP Startup: session.upload_progress.freq must be greater than or >> equal to zero in %s >> string(%d) "1%" >> >> Modified: php/php-src/trunk/ext/session/tests/rfc1867_invalid_settings.phpt >> =================================================================== >> --- php/php-src/trunk/ext/session/tests/rfc1867_invalid_settings.phpt >> 2011-09-04 14:21:27 UTC (rev 316108) >> +++ php/php-src/trunk/ext/session/tests/rfc1867_invalid_settings.phpt >> 2011-09-04 14:28:52 UTC (rev 316109) >> @@ -9,5 +9,7 @@ >> var_dump(ini_get("session.upload_progress.freq")); >> ?> >> --EXPECTF-- >> +PHP Warning: PHP Startup: session.upload_progress.freq must be greater >> than or equal to zero in %s >> + >> Warning: PHP Startup: session.upload_progress.freq must be greater than or >> equal to zero in %s >> string(%d) "1%" >> >> >> -- >> PHP CVS Mailing List (http://www.php.net/) >> To unsubscribe, visit: http://www.php.net/unsub.php >> > > > > -- > Regards, > Shein Alexey > -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
