cataphract                               Sun, 04 Sep 2011 23:00:47 +0000

Revision: http://svn.php.net/viewvc?view=revision&revision=316122

Log:
- Fixed bug #55576: Cannot conditionally move uploaded file without race
  condition.

Bug: https://bugs.php.net/55576 (Open) Race condition in move_uploaded_file()
      
Changed paths:
    U   php/php-src/branches/PHP_5_3/NEWS
    U   php/php-src/branches/PHP_5_3/ext/standard/basic_functions.c
    U   php/php-src/branches/PHP_5_4/ext/standard/basic_functions.c
    U   php/php-src/trunk/ext/standard/basic_functions.c

Modified: php/php-src/branches/PHP_5_3/NEWS
===================================================================
--- php/php-src/branches/PHP_5_3/NEWS   2011-09-04 22:36:33 UTC (rev 316121)
+++ php/php-src/branches/PHP_5_3/NEWS   2011-09-04 23:00:47 UTC (rev 316122)
@@ -5,8 +5,11 @@
 - Core:
   . Fixed bug #52461 (Incomplete doctype and missing xmlns).
     (virsacer at web dot de, Pierre)
-  . Fixed bug #55366: keys lost when using substr_replace an array (Arpad)
-  . Fixed bug #55510: $_FILES 'name' missing first character after upload 
(Arpad)
+  . Fixed bug #55366: keys lost when using substr_replace an array. (Arpad)
+  . Fixed bug #55510: $_FILES 'name' missing first character after upload.
+    (Arpad)
+  . Fixed bug #55576: Cannot conditionally move uploaded file without race
+    condition. (Gustavo)

 - DateTime:
   . Fixed bug #48476 (cloning extended DateTime class without calling

Modified: php/php-src/branches/PHP_5_3/ext/standard/basic_functions.c
===================================================================
--- php/php-src/branches/PHP_5_3/ext/standard/basic_functions.c 2011-09-04 
22:36:33 UTC (rev 316121)
+++ php/php-src/branches/PHP_5_3/ext/standard/basic_functions.c 2011-09-04 
23:00:47 UTC (rev 316122)
@@ -5849,7 +5849,6 @@
                RETURN_FALSE;
        }

-       VCWD_UNLINK(new_path);
        if (VCWD_RENAME(path, new_path) == 0) {
                successful = 1;
 #ifndef PHP_WIN32

Modified: php/php-src/branches/PHP_5_4/ext/standard/basic_functions.c
===================================================================
--- php/php-src/branches/PHP_5_4/ext/standard/basic_functions.c 2011-09-04 
22:36:33 UTC (rev 316121)
+++ php/php-src/branches/PHP_5_4/ext/standard/basic_functions.c 2011-09-04 
23:00:47 UTC (rev 316122)
@@ -5734,7 +5734,6 @@
                RETURN_FALSE;
        }

-       VCWD_UNLINK(new_path);
        if (VCWD_RENAME(path, new_path) == 0) {
                successful = 1;
 #ifndef PHP_WIN32

Modified: php/php-src/trunk/ext/standard/basic_functions.c
===================================================================
--- php/php-src/trunk/ext/standard/basic_functions.c    2011-09-04 22:36:33 UTC 
(rev 316121)
+++ php/php-src/trunk/ext/standard/basic_functions.c    2011-09-04 23:00:47 UTC 
(rev 316122)
@@ -5764,7 +5764,6 @@
                RETURN_FALSE;
        }

-       VCWD_UNLINK(new_path);
        if (VCWD_RENAME(path, new_path) == 0) {
                successful = 1;
 #ifndef PHP_WIN32

-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Reply via email to