bjori                                    Wed, 07 Sep 2011 10:44:32 +0000

Revision: http://svn.php.net/viewvc?view=revision&revision=316330

Log:
Remove bogus skipif and make adjust the tests

Changed paths:
    U   php/php-src/branches/PHP_5_4/Zend/tests/bug39304.phpt
    U   php/php-src/branches/PHP_5_4/Zend/tests/isset_003.phpt
    U   php/php-src/trunk/Zend/tests/bug39304.phpt
    U   php/php-src/trunk/Zend/tests/isset_003.phpt

Modified: php/php-src/branches/PHP_5_4/Zend/tests/bug39304.phpt
===================================================================
--- php/php-src/branches/PHP_5_4/Zend/tests/bug39304.phpt       2011-09-07 
10:41:38 UTC (rev 316329)
+++ php/php-src/branches/PHP_5_4/Zend/tests/bug39304.phpt       2011-09-07 
10:44:32 UTC (rev 316330)
@@ -1,13 +1,16 @@
 --TEST--
 Bug #39304 (Segmentation fault with list unpacking of string offset)
---SKIPIF--
-<?php if (version_compare(zend_version(), '2.4.0', '>=')) die('skip ZendEngine 
2.4 needed'); ?>
 --FILE--
 <?php
   $s = "";
   list($a, $b) = $s[0];
+echo "I am alive";
 ?>
 --EXPECTF--
 Notice: Uninitialized string offset: 0 in %sbug39304.php on line 3

-Fatal error: Cannot use string offset as an array in %sbug39304.php on line 3
+Notice: Uninitialized string offset: 1 in %sbug39304.php on line 3
+
+Notice: Uninitialized string offset: 0 in %sbug39304.php on line 3
+I am alive
+

Modified: php/php-src/branches/PHP_5_4/Zend/tests/isset_003.phpt
===================================================================
--- php/php-src/branches/PHP_5_4/Zend/tests/isset_003.phpt      2011-09-07 
10:41:38 UTC (rev 316329)
+++ php/php-src/branches/PHP_5_4/Zend/tests/isset_003.phpt      2011-09-07 
10:44:32 UTC (rev 316330)
@@ -1,7 +1,5 @@
 --TEST--
 Testing isset accessing undefined array itens and properties
---SKIPIF--
-<?php if (version_compare(zend_version(), '2.4.0', '>=')) die('skip ZendEngine 
2.3 or below needed'); ?>
 --FILE--
 <?php

@@ -31,10 +29,10 @@
 bool(false)
 bool(false)

-Notice: Undefined variable: d in %s on line %d
-
 Notice: Undefined variable: c in %s on line %d

+Notice: Undefined variable: d in %s on line %d
+
 Notice: Trying to get property of non-object in %s on line %d
 bool(false)
 bool(true)

Modified: php/php-src/trunk/Zend/tests/bug39304.phpt
===================================================================
--- php/php-src/trunk/Zend/tests/bug39304.phpt  2011-09-07 10:41:38 UTC (rev 
316329)
+++ php/php-src/trunk/Zend/tests/bug39304.phpt  2011-09-07 10:44:32 UTC (rev 
316330)
@@ -1,13 +1,16 @@
 --TEST--
 Bug #39304 (Segmentation fault with list unpacking of string offset)
---SKIPIF--
-<?php if (version_compare(zend_version(), '2.4.0', '>=')) die('skip ZendEngine 
2.4 needed'); ?>
 --FILE--
 <?php
   $s = "";
   list($a, $b) = $s[0];
+echo "I am alive";
 ?>
 --EXPECTF--
 Notice: Uninitialized string offset: 0 in %sbug39304.php on line 3

-Fatal error: Cannot use string offset as an array in %sbug39304.php on line 3
+Notice: Uninitialized string offset: 1 in %sbug39304.php on line 3
+
+Notice: Uninitialized string offset: 0 in %sbug39304.php on line 3
+I am alive
+

Modified: php/php-src/trunk/Zend/tests/isset_003.phpt
===================================================================
--- php/php-src/trunk/Zend/tests/isset_003.phpt 2011-09-07 10:41:38 UTC (rev 
316329)
+++ php/php-src/trunk/Zend/tests/isset_003.phpt 2011-09-07 10:44:32 UTC (rev 
316330)
@@ -1,7 +1,5 @@
 --TEST--
 Testing isset accessing undefined array itens and properties
---SKIPIF--
-<?php if (version_compare(zend_version(), '2.4.0', '>=')) die('skip ZendEngine 
2.3 or below needed'); ?>
 --FILE--
 <?php

@@ -31,10 +29,10 @@
 bool(false)
 bool(false)

-Notice: Undefined variable: d in %s on line %d
-
 Notice: Undefined variable: c in %s on line %d

+Notice: Undefined variable: d in %s on line %d
+
 Notice: Trying to get property of non-object in %s on line %d
 bool(false)
 bool(true)

-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Reply via email to