Hello, Hannes! It seems your fix is wrong, bug54798 still fails on my machine on trunk, 5.4 and 5.3 branches (ubuntu x64). IMO you should move your patch one line upper, i.e. before call to _php_curl_cleanup_handle(ch); since error is rasing there.
I've also made some patches for this, could you review them and comment what's wrong there, see them and discussion here: http://markmail.org/message/yhywjpaiy3ttgfj5 There's also related bug with curl_multi part, see bug48203_multi.phpt These tests fail for me now on trunk (it seems I forgot to add some of them to other branches, please, consider trunk first): FAILED TEST SUMMARY --------------------------------------------------------------------- Variation of bug #48203 with curl_multi_exec (Crash when file pointers passed to curl are closed before calling curl_multi_exec) [ext/curl/tests/bug48203_multi.phpt] Bug #48203 (Crash when file pointers passed to curl are closed before calling curl_exec) [ext/curl/tests/bug54798.phpt] Memory corruption error if fp of just created file is closed before curl_close. [ext/curl/tests/curl_file_deleted_before_curl_close.phpt] curl_setopt basic tests with CURLOPT_STDERR. [ext/curl/tests/curl_setopt_basic002.phpt] Thanks. 2011/9/8 Hannes Magnusson <bj...@php.net>: > bjori Thu, 08 Sep 2011 14:37:18 +0000 > > Revision: http://svn.php.net/viewvc?view=revision&revision=316417 > > Log: > Fixed bug#54798 Segfault when CURLOPT_STDERR file pointer is closed before > calling curl_exec > > Bug: https://bugs.php.net/54798 (Assigned) Segfault when CURLOPT_STDERR file > pointer is closed before calling curl_exec > > Changed paths: > U php/php-src/branches/PHP_5_3/NEWS > U php/php-src/branches/PHP_5_3/ext/curl/interface.c > U php/php-src/branches/PHP_5_3/ext/curl/tests/bug48203.phpt > A php/php-src/branches/PHP_5_3/ext/curl/tests/bug54798.phpt > U php/php-src/branches/PHP_5_4/ext/curl/interface.c > U php/php-src/branches/PHP_5_4/ext/curl/tests/bug48203.phpt > A php/php-src/branches/PHP_5_4/ext/curl/tests/bug54798.phpt > U php/php-src/trunk/ext/curl/interface.c > U php/php-src/trunk/ext/curl/tests/bug48203.phpt > A php/php-src/trunk/ext/curl/tests/bug54798.phpt > > > -- > PHP CVS Mailing List (http://www.php.net/) > To unsubscribe, visit: http://www.php.net/unsub.php > -- Regards, Shein Alexey -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
