forgot to cc the list, albeit I don't think anybody would be interested. :)


---------- Forwarded message ----------
From: Ferenc Kovacs <tyr...@php.net>
Date: Tue, Sep 27, 2011 at 10:22 AM
Subject: Re: [PHP-CVS] svn: /php/php-src/
branches/PHP_5_3/ext/calendar/tests/bug53574.phpt
branches/PHP_5_3/ext/calendar/tests/bug53574_1.phpt
branches/PHP_5_3/ext/calendar/tests/bug53574_2.phpt
branches/PHP_5_4/ext/calendar/tests/bug53574.phpt branches/PHP_
To: Christopher Jones <christopher.jo...@oracle.com>


you missed dow, but yeah, only the day related fields are providing
non null values.
as you can see, it is calculated through simple modulo, so this is why
it can always provide a sensible result:
http://lxr.php.net/opengrok/xref/PHP_TRUNK/ext/calendar/calendar.c#416
http://lxr.php.net/xref/PHP_TRUNK/ext/calendar/dow.c#34
maybe we should check the return value of from_jd or the value of
year/month/day before calculating the the day related fields.

On Tue, Sep 27, 2011 at 3:15 AM, Christopher Jones
<christopher.jo...@oracle.com> wrote:
>
> My gut feel about this, from looking only at the phpt files, is
> that either there should be an error given or the day name
> fields should be empty strings.  Only those two fields make
> an attempt to populate a sensible value, the other fields
> look like defaults e.g. "0/0/0".  This seems inconsistent.
>
> Chris
>
> On 09/26/2011 05:53 PM, Ferenc Kovacs wrote:
>>
>> tyrael                                   Tue, 27 Sep 2011 00:53:41 +0000
>>
>> Revision: http://svn.php.net/viewvc?view=revision&revision=317366
>>
>> Log:
>> split the ext/calendar/tests/bug53574.phpt into two test, as we expect
>> different result on 32 and 64 bit
>>
>> Bug: https://bugs.php.net/53574 (Re-Opened) Integer overflow in
>> SdnToJulian
>>
>> Changed paths:
>>     D   php/php-src/branches/PHP_5_3/ext/calendar/tests/bug53574.phpt
>>     A + php/php-src/branches/PHP_5_3/ext/calendar/tests/bug53574_1.phpt
>>         (from
>> php/php-src/branches/PHP_5_3/ext/calendar/tests/bug53574.phpt:r317364)
>>     A + php/php-src/branches/PHP_5_3/ext/calendar/tests/bug53574_2.phpt
>>         (from
>> php/php-src/branches/PHP_5_3/ext/calendar/tests/bug53574.phpt:r317364)
>>     D   php/php-src/branches/PHP_5_4/ext/calendar/tests/bug53574.phpt
>>     A + php/php-src/branches/PHP_5_4/ext/calendar/tests/bug53574_1.phpt
>>         (from
>> php/php-src/branches/PHP_5_4/ext/calendar/tests/bug53574.phpt:r317364)
>>     A + php/php-src/branches/PHP_5_4/ext/calendar/tests/bug53574_2.phpt
>>         (from
>> php/php-src/branches/PHP_5_4/ext/calendar/tests/bug53574.phpt:r317364)
>>     D   php/php-src/trunk/ext/calendar/tests/bug53574.phpt
>>     A + php/php-src/trunk/ext/calendar/tests/bug53574_1.phpt
>>         (from php/php-src/trunk/ext/calendar/tests/bug53574.phpt:r317364)
>>     A + php/php-src/trunk/ext/calendar/tests/bug53574_2.phpt
>>         (from php/php-src/trunk/ext/calendar/tests/bug53574.phpt:r317364)
>>
>>
>>
>>
>
> --
> Email: christopher.jo...@oracle.com
> Tel:  +1 650 506 8630
> Blog:  http://blogs.oracle.com/opal/
>

--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Reply via email to