Commit:    4054890b26c4d146cfbcd56d75aab7a7aebc8c89
Author:    Matt Ficken <mattfic...@php.net>         Tue, 29 May 2012 11:41:44 
+0200
Committer: Anatoliy Belsky <a...@php.net>      Tue, 29 May 2012 11:41:44 +0200
Parents:   72911237b55d9eaaa48a046cbd7cbc4c195c1ee3
Branches:  PHP-5.3 PHP-5.4 master

Link:       
http://git.php.net/?p=php-src.git;a=commitdiff;h=4054890b26c4d146cfbcd56d75aab7a7aebc8c89

Log:
Fixed bug #62176 Test Bug - sapi/cli/tests/bug61546.phpt

Bugs:
https://bugs.php.net/62176
https://bugs.php.net/61546

Changed paths:
  M  sapi/cli/tests/bug61546.phpt


Diff:
diff --git a/sapi/cli/tests/bug61546.phpt b/sapi/cli/tests/bug61546.phpt
index 2cd690f..071edb7 100644
--- a/sapi/cli/tests/bug61546.phpt
+++ b/sapi/cli/tests/bug61546.phpt
@@ -2,13 +2,22 @@
 Bug #61546 (functions related to current script failed when chdir() in cli 
sapi)
 --FILE--
 <?php
+// reference doc for getmyinode() on php.net states that it returns an integer 
or FALSE on error
+// on Windows, getmyinode() returns 0 which normally casts to FALSE
+// however, the implementation of getmyinode() (in pageinfo.c) returns an 
explicit FALSE in the
+// event that the internal page_inode structure is less than 0, otherwise it 
returns the long value
+// of page_inode. therefore, an explicit 0 should be a passing value for this 
test.
+//
+// the ext/standard/tests/file/statpage.phpt test also tests getmyinode() 
returns an integer and will
+// pass even if that integer is 0. on Windows, the getmyinode() call in 
statpage.phpt returns 0 and
+// passes on Windows.
 $php = getenv("TEST_PHP_EXECUTABLE");
 $test_code = <<<PHP
 <?php
 chdir('..');
 var_dump(get_current_user() != "");
 chdir('..');
-var_dump(getmyinode() != false);
+var_dump(getmyinode() !== false);
 var_dump(getlastmod() != false);
 PHP;


--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Reply via email to