> I'm not sure that this change is right. As it is now one could no
> longer pass in "123" (as a string) or 123.0 (as a float) as
> limit/offset. This goes against usual PHP semantics.

I agree, this:
>> -                       if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, 
>> "O|ll", &zobject, ce_inner, &intern->u.limit.offset, &intern->u.limit.count) 
>> == FAILURE) {
>> +                       if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, 
>> "O|zz", &zobject, ce_inner, &tmp_offset, &tmp_count) == FAILURE) {

Is wrong, especially added in 5.3/5.4. I'm getting complaints here about
changes that only theoretically affect some future extensions, but here
we got API change in stable version that would deny things like "1" in
numeric context, which is completely contrary to how PHP does things.

Please revert this change.
Stanislav Malyshev, Software Architect
SugarCRM: http://www.sugarcrm.com/
(408)454-6900 ext. 227

PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Reply via email to