Em Tue, 17 Jul 2012 23:49:55 +0200, Stas Malyshev <smalys...@sugarcrm.com>
Author: Reeze Xia <reeze....@gmail.com> Tue, 17 Jul 2012
Committer: Gustavo André dos Santos Lopes <cataphr...@php.net>
Tue, 17 Jul 2012 23:08:11 +0200
Branches: PHP-5.4 master
Fix test fails: ext/standard/tests/general_functions/bug27678.phpt
After commit 3e62aae1, number_format() returns string with length,
but _php_math_number_format_ex_len() didn't set string length
on nan and inf. This cause segfault when destruct the return value.
Thanks for fixing it! However that means I'd have to revert the original
fix 3e62aae1b456440328af4153524e22679b84f68a from 5.4.5, since it's not
correct but I don't want to make a new RC out of it which would be
necessary if I added this new patch.
I think that's overly cautious given the simplicity of the problem and the
fix, but it's your call.
But even as a matter of principle, I don't know why you'd need a new RC in
one case, but not in the other. You'd have a release different from the
last RC in both cases. It's true that the revert would only restore old
code, but, in general, you can't be sure the old code is still correct in
the context of the other changes since the last release (i.e. something
else could rely on the change. In principle).
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php