Hi,

2012/7/29 Hannes Magnusson <hannes.magnus...@gmail.com>:
> On Sat, Jul 28, 2012 at 11:05 PM, Felipe Pena <fel...@php.net> wrote:
>> Commit:    068fc008c6828c2e045064a831ecb90136c6365b
>> Author:    Felipe Pena <felipe...@gmail.com>         Sat, 28 Jul 2012 
>> 19:05:13 -0300
>> Parents:   b477a84026a39a58452af9676b4b74607e83e2f8
>> Branches:  PHP-5.3 PHP-5.4 master
>>
>> Link:       
>> http://git.php.net/?p=php-src.git;a=commitdiff;h=068fc008c6828c2e045064a831ecb90136c6365b
>>
>> Log:
>> - Fixed bug #57933 (Wrong table type used in phpinfo output) patch by: 
>> selsky at columbia dot edu
>>
>> Bugs:
>> https://bugs.php.net/57933
>>
>> Changed paths:
>>   M  ext/fileinfo/fileinfo.c
>>
>>
>> Diff:
>> diff --git a/ext/fileinfo/fileinfo.c b/ext/fileinfo/fileinfo.c
>> index 36c5e39..0c82898 100644
>> --- a/ext/fileinfo/fileinfo.c
>> +++ b/ext/fileinfo/fileinfo.c
>> @@ -271,7 +271,7 @@ ZEND_GET_MODULE(fileinfo)
>>  PHP_MINFO_FUNCTION(fileinfo)
>>  {
>>         php_info_print_table_start();
>> -       php_info_print_table_header(2, "fileinfo support", "enabled");
>> +       php_info_print_table_row(2, "fileinfo support", "enabled");
>>         php_info_print_table_row(2, "version", PHP_FILEINFO_VERSION);
>>         php_info_print_table_end();
>
>
> That seems to be the standard practice to have the enabled row a table header:
>
> (PHP-5.4) $ git grep php_info_print_table_header.*enabled | wc -l
>       34
>
> After this commit the only extension that doesn't use a table header
> for "enabled" is fileinfo..
>

Well, I have checked it before, so here we goes:

$ grep -r 'php_info_print_table_row.*enabled' ext/*/*.c | wc -l
82

-- 
Regards,
Felipe Pena

-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Reply via email to