On Tue, 30 Apr 2013 19:59:19 +0200, Stas Malyshev <smalys...@sugarcrm.com>

Fix bug #64729: compilation failure on x32

Could you explain this patch? I regularly compile PHP on both 32-bit and
64-bit platforms and never had any errors. Is it some special version of
the compiler? Some particular OS?

This is for the x32 ABI [1], which is quite recent. There were compilation
failures because some inline asm blocks for x86-64 were not appropriate
for x32. It did not fallback to the non-asm version because __x86_64__ is
defined also for x32.

I checked that there were effectively no differences whatsoever in
generated code for x86-64 after the patch (and all the tests passed as
well, of course). The only risk is whether the modified code fails on old
versions of the GNU assembler because some instructions are not suffixed
with 'q' anymore, leaving the instruction form to be inferred based on the
type of the registers.

[1] http://en.wikipedia.org/wiki/X32_ABI

Gustavo Lopes

PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Reply via email to