Re: [PHP-CVS] com php-src: Address feature request #38917 for native SPKAC (HTML5 keygen element) support: ext/openssl/openssl.c ext/openssl/php_openssl.h ext/openssl/tests/openssl_spki_export.phpt ext/openssl/tests/openssl_spki_export_challenge.phpt ext/openssl/tests/openssl_spki_new.phpt ext/openssl/tests/openssl_spki_verify.phpt

[Kalle Sommer Nielsen]

Hi Jason

2013/5/7 Jason Gerfen <j...@php.net>:
> Commit:    8f56ac8401ed1c3e00b8fba3fb8e5efb565180c4
> Author:    jas- <jason.ger...@gmail.com>         Mon, 6 May 2013 16:36:06 
> -0600
> Parents:   da07e91c3a7e7bac2e380f24c59f70c1bcb3e7e4
> Branches:  master
>
> Link:       
> http://git.php.net/?p=php-src.git;a=commitdiff;h=8f56ac8401ed1c3e00b8fba3fb8e5efb565180c4
>
> Log:
> Address feature request #38917 for native SPKAC (HTML5 keygen element) support
>
> Bugs:
> https://bugs.php.net/38917

+               ASN1_STRING_set(spki->spkac->challenge, challenge, 
(int)strlen(challenge));

Since we don't modify challenge here, wouldn't be smarter to use
challenge_len we already get from zend_parse_parameters() or did I
miss something? =P

-- 
regards,

Kalle Sommer Nielsen
ka...@php.net

-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php