Commit:    cbf90b1a908d8f5c1799a1e206b968f393ba7d99
Author:    Nikita Popov <ni...@php.net>         Sun, 24 Mar 2013 17:52:16 +0100
Committer: Matteo Beccati <mbecc...@php.net>      Sun, 2 Jun 2013 13:28:30 +0200
Parents:   51c065f611c563c4b9fc0432be27fafd99424d8e
Branches:  PHP-5.4 PHP-5.5 master

Link:       
http://git.php.net/?p=php-src.git;a=commitdiff;h=cbf90b1a908d8f5c1799a1e206b968f393ba7d99

Log:
Fix PDO::inTransaction() test for pgsql

inTransaction() nowadays casts the in_transaction result to boolean.
I'm not sure whether the INERROR state should result in true or false.
For now I went with the result that we actually get.

Changed paths:
  M  ext/pdo_pgsql/tests/is_in_transaction.phpt


Diff:
diff --git a/ext/pdo_pgsql/tests/is_in_transaction.phpt 
b/ext/pdo_pgsql/tests/is_in_transaction.phpt
index 99ff561..72da4f4 100644
--- a/ext/pdo_pgsql/tests/is_in_transaction.phpt
+++ b/ext/pdo_pgsql/tests/is_in_transaction.phpt
@@ -57,10 +57,10 @@ var_dump($db->inTransaction());
 ?>
 --EXPECT--
 Test PDO::PGSQL_TRANSACTION_INTRANS
-int(2)
+bool(true)
 Test PDO::PGSQL_TRANSACTION_IDLE
-int(0)
+bool(false)
 Test PDO::PGSQL_TRANSACTION_INERROR
-int(3)
+bool(true)
 Test PDO::PGSQL_TRANSACTION_IDLE
-int(0)
+bool(false)


--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Reply via email to