On 21 June 2013 11:01, Dmitry Stogov <dmi...@zend.com> wrote: > I think it's better to apply the same patch to 5.4 and 5.5 as well. > It's absolutely safe. >
OK done! -- Ard. > Thanks. Dmitry. > > > On Fri, Jun 21, 2013 at 12:51 PM, Ard Biesheuvel <ard.biesheu...@linaro.org> > wrote: >> >> On 20 June 2013 23:28, Christopher Jones <christopher.jo...@oracle.com> >> wrote: >> > Your @internals mail said "building the executor without >> > specialization is broken" so the patch seems like a standard bug fix >> > that should be merged to 5.4 & 5.5. >> > >> >> By 'building' I mean running 'zend_vm_gen.php --without-specializer' >> to generate zend_vm_opcodes.h and zend_vm_execute.h, which is a way >> that is arguably non-standard, proven by the fact that this particular >> mode has been broken since November 2010. In fact, when running this >> script in the conventional way, the produced code is identical to the >> code that is already in the repository. >> >> @Dmitry: there's a request to backport the FREE_OP2() fixes to 5.5 and >> 5.4, what do you think? >> >> -- >> Ard. > > -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php