On Thu, Aug 22, 2013 at 12:06 AM, Christopher Jones <s...@php.net> wrote:
> Commit: f38bd22ed2c5f710f72e719d7ab2a41ce30541fc > Author: Christopher Jones <s...@php.net> Wed, 21 Aug 2013 > 15:06:23 -0700 > Parents: d8023d13eb5c5c611a17b183b28c0a81233d8a1a > Branches: PHP-5.4 PHP-5.5 master > > Link: > http://git.php.net/?p=php-src.git;a=commitdiff;h=f38bd22ed2c5f710f72e719d7ab2a41ce30541fc > > Log: > Suppress compliation warning "warning: passing argument 1 of ‘_efree’ > discards qualifiers from pointer target type" > > Changed paths: > M ext/intl/intl_data.h > > > Diff: > diff --git a/ext/intl/intl_data.h b/ext/intl/intl_data.h > index 66ca27a..6966dc2 100644 > --- a/ext/intl/intl_data.h > +++ b/ext/intl/intl_data.h > @@ -79,7 +79,7 @@ typedef struct _intl_data { > int u8len; > > \ > intl_convert_utf16_to_utf8(&u8value, &u8len, ustring, ulen, > &INTL_DATA_ERROR_CODE((obj))); \ > if((free_it)) { > > \ > - efree(ustring); > > \ > + efree((void *)ustring); > > \ > } > > \ > INTL_METHOD_CHECK_STATUS((obj), "Error converting value to > UTF-8"); \ > RETVAL_STRINGL(u8value, u8len, 0); > > \ Assuming this suppresses a `const` qualifier, wouldn't it be better to remove said qualifier, rather than suppressing the warning? Nikita
