Commit:    6fab1caa4100cf05fcf485ef0917830ae9f57563
Author:    Remi Collet <r...@php.net>         Fri, 30 Aug 2013 10:45:33 +0200
Parents:   a5749eb0cbe6edb91ba0d5d79bbeedaeabf3788a
Branches:  PHP-5.5 master

Link:       
http://git.php.net/?p=php-src.git;a=commitdiff;h=6fab1caa4100cf05fcf485ef0917830ae9f57563

Log:
Fixed bug #65564 stack-buffer-overflow in DateTimeZone stuff caught by 
AddressSanitizer

Bugs:
https://bugs.php.net/65564

Changed paths:
  M  NEWS
  M  ext/date/php_date.c


Diff:
diff --git a/NEWS b/NEWS
index d637d0a..ab1b5ca 100644
--- a/NEWS
+++ b/NEWS
@@ -25,6 +25,8 @@ PHP                                                           
             NEWS
 - Datetime:
   . Fixed bug #65554 (createFromFormat broken when weekday name is followed
     by some delimiters). (Valentin Logvinskiy, Stas).
+  . Fixed bug #65564 (stack-buffer-overflow in DateTimeZone stuff caught
+    by AddressSanitizer). (Remi).
 
 - OPCache:
   . Fixed bug #65561 (Zend Opcache on Solaris 11 x86 needs 
ZEND_MM_ALIGNMENT=4).
diff --git a/ext/date/php_date.c b/ext/date/php_date.c
index 997038a..95c68f1 100644
--- a/ext/date/php_date.c
+++ b/ext/date/php_date.c
@@ -2305,7 +2305,7 @@ static HashTable 
*date_object_get_properties_timezone(zval *object TSRMLS_DC)
 
        MAKE_STD_ZVAL(zv);
        ZVAL_LONG(zv, tzobj->type);
-       zend_hash_update(props, "timezone_type", 14, &zv, sizeof(zval), NULL);
+       zend_hash_update(props, "timezone_type", 14, &zv, sizeof(zv), NULL);
 
        MAKE_STD_ZVAL(zv);
        switch (tzobj->type) {
@@ -2327,7 +2327,7 @@ static HashTable 
*date_object_get_properties_timezone(zval *object TSRMLS_DC)
                        ZVAL_STRING(zv, tzobj->tzi.z.abbr, 1);
                        break;
        }
-       zend_hash_update(props, "timezone", 9, &zv, sizeof(zval), NULL);
+       zend_hash_update(props, "timezone", 9, &zv, sizeof(zv), NULL);
 
        return props;
 }


--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Reply via email to