On 2013-09-27 12:48, Dmitry Stogov wrote:
Hi Antony,
I'm not sure if switching from zend_error() to php_error_docref() would improve
usability.
Well, IIRC the only difference is that it generates nice links to the docs and
you're about to have those.
Also I'm not sure all the cases when E_ERROR is used are reasonable, shouldn't
they be something else?
ext/opcache/zend_accelerator_util_funcs.c:481: zend_error(E_ERROR,
ACCELERATOR_PRODUCT_NAME " class loading error, class %s, function %s. Please call Zend
Support", ce->name, new_entry->function_name);
ext/opcache/zend_accelerator_util_funcs.c:490: zend_error(E_ERROR,
ACCELERATOR_PRODUCT_NAME " class loading error, class %s, function %s. Please call Zend
Support", ce->name, new_entry->function_name);
ext/opcache/zend_accelerator_util_funcs.c:592: zend_error(E_ERROR,
ACCELERATOR_PRODUCT_NAME" class loading error, class %s, property %s. Please call Zend
Support", ce->name, prop_info->name);
ext/opcache/zend_accelerator_util_funcs.c:624: zend_error(E_ERROR,
ACCELERATOR_PRODUCT_NAME " class loading error, class %s. Please call Zend
Support", ce->name); \
ext/opcache/zend_accelerator_util_funcs.c:713: zend_error(E_ERROR,
ACCELERATOR_PRODUCT_NAME" class loading error, class %s. Please call Zend
Support", ce->name);
ext/opcache/zend_accelerator_util_funcs.c:874: zend_error(E_ERROR,
"Cannot redeclare %s() (previously declared in %s:%d)",
ext/opcache/zend_accelerator_util_funcs.c:879: zend_error(E_ERROR,
"Cannot redeclare %s()", function1->common.function_name);
ext/opcache/zend_accelerator_util_funcs.c:897: zend_error(E_ERROR, "Cannot
redeclare class %s", (*pce1)->name);
E_RECOVERABLE_ERROR maybe?
I'll remove reference to Zend Support :)
It, provably, came from an old private version.
Thanks for caching this.
Sure, that was obvious =)
--
Wbr,
Antony Dovgal
---
http://pinba.org - realtime profiling for PHP
--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
