Yup, Matthew's right. I definitely forgot the other $sql. = that needs to go
in front of the WHERE clause.

Question for Matthew though:

Is this:
>       $sql .= "UPDATE newdacs";
>       $sql .= "SET emailfwd='$emailfwd',";
>       $sql .= "mformat='$mformat',"
>       $sql .= "filter_code='$filter_code'";

Pretty much the same as this:
> >             $sql = "UPDATE newdacs
> >                     SET emailfwd='$emailfwd',
> >                     mformat='$mformat',
> >                     filter_code='$filter_code'";

I mean, the line breaks in the second example won't cause the query to bomb,
will they? I agree that using the $sql .= is cleaner, but the other way
isn't wrong, is it?

Rich

> -----Original Message-----
> From: Matthew Moldvan [mailto:[EMAIL PROTECTED]
> Sent: Tuesday, June 10, 2003 11:33 AM
> To: 'Susan Ator'; '[EMAIL PROTECTED]'
> Subject: RE: [PHP-DB] Is this query even possible?
> 
> 
> I would say something like the following would work better:
> 
> if($FUNC=="USERPOST" || $FUNC=="MODU")
> {
>       $sql .= "UPDATE newdacs";
>       $sql .= "SET emailfwd='$emailfwd',";
>       $sql .= "mformat='$mformat',"
>       $sql .= "filter_code='$filter_code'";
>       if($FUNC=='USERPOST')
>               $sql .= ", unote='$unote'";
>       $sql .= "WHERE user_id='$user_id'";
> 
>       $result = mysql_query($sql) or die('mysql error 
> #'.mysql_errno.':
> 'mysql_error());
> }
> 
> Try that ... also look into www.php.net under string 
> manipulation for other
> options.
> 
> Regards,
> Matthew Moldvan
>  
> System Administrator
> Trilogy International, Inc.
> 
> -----Original Message-----
> From: Susan Ator [mailto:[EMAIL PROTECTED]
> Sent: Tuesday, June 10, 2003 11:18 AM
> To: '[EMAIL PROTECTED]'
> Subject: [PHP-DB] Is this query even possible?
> 
> 
> > This is what I am trying to do:
> > 
> >     if ($FUNC==("USERPOST") || $FUNC==("MODU")) {
> >             $sql = "UPDATE newdacs
> >                     SET emailfwd='$emailfwd',
> >                     mformat='$mformat',
> >                     filter_code='$filter_code'
> >                     if ($FUNC=='USERPOST') {
> >                             ,unote='$unote'
> >                     }
> >                     WHERE user_id='$user_id'";
> >             $set_newdacs_result = mysql_query($sql) or print
> > mysql_error();
> >     }
> > 
> > There are several more queries like this which is why I 
> want to avoid
> > duplicating the code since there are only 1 or 2 
> differences between them
> > depending on function call.
> > 
> > This is the error I am getting:
> > 
> >     You have an error in your SQL syntax near 'if 
> (USERPOST=='USERPOST')
> > { ,unote='' } WHERE user_id='2'' at line 5
> > 
> > Is what I am attempting possible or am I spinning my wheels?
> > 
> > susan
> 
> -- 
> PHP Database Mailing List (http://www.php.net/)
> To unsubscribe, visit: http://www.php.net/unsub.php
> 
> -- 
> PHP Database Mailing List (http://www.php.net/)
> To unsubscribe, visit: http://www.php.net/unsub.php
> 

-- 
PHP Database Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Reply via email to