On 12/18/2010 9:17 PM, Ethan Rosenberg wrote:
Dear List -

Thanks to all for your EXCELLENT comments. I definitly agree that goto
is a command to be avoided at all costs. In this case, I could not
figure out how to acheive the desired result without the goto. So....
being a newbie, I humbly request that you show [and at the same time
teach] me how to rewrite the code to eleiminate the goto.

Additionally, would you please do the same for the code I list below.
This code runs perfectly.
This is the form:

<form action="srchrhsptl2.php" method="post">
<center>Site: <input type="text" name="Site" value="AA" />
Record Number: <input type="text" name="MedRec" />
First Name: <input type="text" name="Fname" />
Last Name: <input type="text" name="Lname" /><br /><br />
Phone: <input type="text" name="Phone" />
Height: <input type="decimal" name="Height" /></input><br /><br />
Male<input type="radio" name="Sex" value = "0"></input>
Female<input type="radio" name="Sex" value = "1"></input><br /><br /><br />
<input type="submit" /><br /><br />
<input type="reset" value = "Clear Form" /></center>

Not sure if you can change the values for the Sex field to 'Male' & 'Female' respectively, but it would simplify the following example.

Here is my rendition of how I would do it.



$query = "select * from Intake3 where 1 ";

$allowed_fields = array('Site', 'MedRe', 'Fname', 'Lname',
                        'Phone', 'Sex', 'Height');

# deal with the special case first
# Normally you do not want to modify the _POST/_GET/_REQUEST array, but
# in this case, it is used as an quick example of how to get the data
# passed along. if you can change the field values to Male/Female you
# could remove the following section and have just the foreach() loop.
if ( ! empty($_POST['Sex']) )
        if ( $_POST['Sex'] === '1' )
                $_POST['Sex'] = 'Female';
                $_POST['Sex'] = 'Male';

# Now deal with the rest...
foreach ( $allowed_fields AS $field )
        if ( ! empty( $_POST[$field] ) )
                $value = mysql_real_escape_string( $_POST[$field] );
                $query .= " AND `{$field}` = '{$value}' ";

in the end, you will end up with a nicely formatted SQL query to execute.

I would suggest cleaning up the output code some and use *_assoc() instead of the *_array() function call. It gives you back the array version of the output. This way instead of calling $row[0], $row[...] you would call $row['Fname'] or $row['Lname'] instead.

Get rid of all those commented out sections and you will have a good script to play with.

Let us know what comes of it...



PHP Database Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Reply via email to