That looks like leftovers from earlier builds - the latest CVS is fine in
that regard. I also fixes the non-ZTS problems.
Zeev
At 01:21 14/1/2001, Sean R. Bright wrote:
>Thanks, you may want to check it thread safe again as well. Getting alot of
>errors that look like this:
>
>/usr/cvs/php4/ext/standard/exec.c:53: undefined reference to
>`core_globals_id'
>/usr/cvs/php4/ext/standard/exec.c:53: undefined reference to
>`ts_resource_ex'
>/usr/cvs/php4/ext/standard/exec.c:54: undefined reference to
>`ts_resource_ex'
>
>Might just be my env, but I did get a clean copy from CVS.
>
>Thanks,
>Sean
>
> > -----Original Message-----
> > From: Zeev Suraski [mailto:[EMAIL PROTECTED]]
> > Sent: Saturday, January 13, 2001 6:28 PM
> > To: [EMAIL PROTECTED]
> > Cc: [EMAIL PROTECTED]
> > Subject: Re: FW: [PHP-DEV] file.c fsock.c ... Again ...
> >
> >
> > Ok, I did the development under Windows and didn't check the
> > thread-unsafe
> > mode. I'll fix it.
> >
> > At 00:54 14/1/2001, Sean R. Bright wrote:
> >
> > >Already did, these are happening after getting your changes.
> > (I watch the
> > >cvs list as well ;))
> > >
> > > > -----Original Message-----
> > > > From: Derick Rethans [mailto:[EMAIL PROTECTED]]
> > > > Sent: Saturday, January 13, 2001 6:04 PM
> > > > To: Sean R. Bright
> > > > Cc: [EMAIL PROTECTED]
> > > > Subject: Re: [PHP-DEV] file.c fsock.c ... Again ...
> > > >
> > > >
> > > > Hello,
> > > >
> > > > can you try the latest CVS? Zeev did some work on it today.
> > > >
> > > > Derick
> > > >
> > > > On Sat, 13 Jan 2001, Sean R. Bright wrote:
> > > >
> > > > >
> > > > > Anyone see the logical problem with this besides me?
> > > > >
> > > > > #ifdef ZTS
> > > > > static void file_globals_ctor(FLS_D) <--- THIS is defined
> > > > if thread safe
> > > > > {
> > > > > zend_hash_init(&FG(ht_fsock_keys), 0, NULL, NULL, 1);
> > > > > zend_hash_init(&FG(ht_fsock_socks), 0, NULL,
> > (void (*)(void
> > > > > *))php_msock_destroy, 1);
> > > > > FG(def_chunk_size) = PHP_FSOCK_CHUNK_SIZE;
> > > > > FG(phpsockbuf) = NULL;
> > > > > FG(fgetss_state) = 0;
> > > > > FG(pclose_ret) = 0;
> > > > > }
> > > > > static void file_globals_dtor(FLS_D)
> > > > > {
> > > > > zend_hash_destroy(&FG(ht_fsock_socks));
> > > > > zend_hash_destroy(&FG(ht_fsock_keys));
> > > > > php_cleanup_sockbuf(1 FLS_CC);
> > > > > }
> > > > > #endif
> > > > >
> > > > > PHP_MINIT_FUNCTION(file)
> > > > > {
> > > > > le_fopen =
> > > > zend_register_list_destructors_ex(_file_fopen_dtor, NULL,
> > > > > "file", module_number);
> > > > > le_popen =
> > > > zend_register_list_destructors_ex(_file_popen_dtor, NULL,
> > > > > "pipe", module_number);
> > > > > le_socket =
> > > > zend_register_list_destructors_ex(_file_socket_dtor,
> > > > > NULL, "socket", module_number);
> > > > >
> > > > > #ifdef ZTS
> > > > > file_globals_id =
> > ts_allocate_id(sizeof(php_file_globals),
> > > > > (ts_allocate_ctor) file_globals_ctor,
> > (ts_allocate_dtor) file_gl$
> > > > > #else
> > > > > file_globals_ctor(FLS_C); <--- BUT is called when
> > > > not thread safe
> > > > > (i.e. its not defined...
> > > > > #endif
> > > > >
> > > > > Errors happening:
> > > > >
> > > > > .libs/libphp4.a(file.o): In function `php_minit_file':
> > > > > /usr/cvs/php4/ext/standard/file.c:179: undefined reference to
> > > > > `file_globals_ctor'
> > > > > .libs/libphp4.a(fsock.o): In function `php_mshutdown_fsock':
> > > > > /usr/cvs/php4/ext/standard/fsock.c:726: undefined reference to
> > > > > `fsock_globals_dtor'
> > > > > collect2: ld returned 1 exit status
> > > > >
> > > > >
> > > > >
> > > >
> > >
> > >
> > >--
> > >PHP Development Mailing List <http://www.php.net/>
> > >To unsubscribe, e-mail: [EMAIL PROTECTED]
> > >For additional commands, e-mail: [EMAIL PROTECTED]
> > >To contact the list administrators, e-mail:
> > [EMAIL PROTECTED]
> >
> > --
> > Zeev Suraski <[EMAIL PROTECTED]>
> > CTO & co-founder, Zend Technologies Ltd. http://www.zend.com/
> >
> >
> > --
> > PHP Development Mailing List <http://www.php.net/>
> > To unsubscribe, e-mail: [EMAIL PROTECTED]
> > For additional commands, e-mail: [EMAIL PROTECTED]
> > To contact the list administrators, e-mail:
> > [EMAIL PROTECTED]
> >
>
>
>--
>PHP Development Mailing List <http://www.php.net/>
>To unsubscribe, e-mail: [EMAIL PROTECTED]
>For additional commands, e-mail: [EMAIL PROTECTED]
>To contact the list administrators, e-mail: [EMAIL PROTECTED]
--
Zeev Suraski <[EMAIL PROTECTED]>
CTO & co-founder, Zend Technologies Ltd. http://www.zend.com/
--
PHP Development Mailing List <http://www.php.net/>
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
To contact the list administrators, e-mail: [EMAIL PROTECTED]
