Is there a reason the *log_message argument to the log functions isn't
'const'? Making it a 'const char *' seems more correct, but I'm not
sure if that will break on some platforms.
The attached patch adds 'const' to the *log_message argument in a few
places.
--
Jon Parise ([EMAIL PROTECTED]) . Rochester Inst. of Technology
http://www.csh.rit.edu/~jon/ : Computer Science House Member
Index: main/SAPI.h
===================================================================
RCS file: /repository/php4/main/SAPI.h,v
retrieving revision 1.68
diff -u -r1.68 SAPI.h
--- main/SAPI.h 2001/03/18 02:32:04 1.68
+++ main/SAPI.h 2001/04/07 05:11:52
@@ -182,7 +182,7 @@
char *(*read_cookies)(SLS_D);
void (*register_server_variables)(zval *track_vars_array ELS_DC SLS_DC PLS_DC);
- void (*log_message)(char *message);
+ void (*log_message)(const char *message);
char *php_ini_path_override;
Index: main/main.c
===================================================================
RCS file: /repository/php4/main/main.c,v
retrieving revision 1.358
diff -u -r1.358 main.c
--- main/main.c 2001/04/04 20:46:26 1.358
+++ main/main.c 2001/04/07 05:11:52
@@ -251,7 +251,7 @@
/* True global (no need for thread safety */
static int module_initialized = 0;
-void php_log_err(char *log_message)
+void php_log_err(const char *log_message)
{
FILE *log_file;
char error_time_str[128];
Index: main/php.h
===================================================================
RCS file: /repository/php4/main/php.h,v
retrieving revision 1.134
diff -u -r1.134 php.h
--- main/php.h 2001/02/26 18:14:30 1.134
+++ main/php.h 2001/04/07 05:11:53
@@ -239,7 +239,7 @@
void phperror(char *error);
PHPAPI int php_write(void *buf, uint size);
PHPAPI int php_printf(const char *format, ...);
-void php_log_err(char *log_message);
+void php_log_err(const char *log_message);
int Debug(char *format, ...);
int cfgparse(void);
--
PHP Development Mailing List <http://www.php.net/>
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
To contact the list administrators, e-mail: [EMAIL PROTECTED]
