On Tue, Jun 19, 2001 at 09:55:08PM +0300 , Andi Gutmans wrote:
> Part of the getting back to normal process is getting 4.0.6 out of the door :)
> Please test it http://www.php.net/~andi/php-4.0.6RC4.tar.gz
> I *really* would like to get it out.

here are some bugs I came around during packaging for Debian

1) sapi/caudium/config.m4 - install doesn't honor INSTALL_ROOT and also
doesn't create dir for the module
-       INSTALL_IT="\$(INSTALL) -m 0755 $SAPI_SHARED 
+       INSTALL_IT="\$(mkinstalldirs) \$(INSTALL_ROOT)$withval/lib/$PIKE_VERSION/ && 
+\$(INSTALL) -m 0755 $SAPI_SHARED \$(INSTALL_ROOT)$withval/lib/$PIKE_VERSION/PHP4.so"

2) ext/sablot/config.m4 cannot be build as DSO, because the second test for
expat-dir destroys ext_shared from --with-sablot and as a result it adds
libraries to the main libphp4.so and not to sablot.so

 PHP_ARG_WITH(sablot, for Sablotron XSL support,
 [  --with-sablot[=DIR]     Include Sablotron support])

 PHP_ARG_WITH(expat-dir, libexpat dir for Sablotron 0.50,
 [  --with-expat-dir=DIR    Sablotron: libexpat dir for Sablotron 0.50])
 if test "$PHP_SABLOT" != "no"; then

-  PHP_EXTENSION(sablot, $ext_shared)
+  PHP_EXTENSION(sablot, $php_ext_shared)

-      PHP_ADD_LIBRARY_WITH_PATH(expat, $i/lib)

3) the type of regoff_t is bad. libc defines it as int and if you use large
file support (LFS, -DLARGE_SOURCE ....) it breaks, because off_t is 64bit.
The same should be applied to apache (include/hsregex.h)

--- regex/regex.h
+++ regex/regex.h
@@ -14,7 +14,7 @@
 #define API_EXPORT(type)    type

-typedef off_t regoff_t;
+typedef int regoff_t;
 typedef struct {
        int re_magic;

                                Petr Cech
Debian GNU/Linux maintainer - www.debian.{org,cz}
           [EMAIL PROTECTED]

* Joy sees a potato running down the street and shouting "I'm late! I'm late!" ;))

PHP Development Mailing List <http://www.php.net/>
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
To contact the list administrators, e-mail: [EMAIL PROTECTED]

Reply via email to