From:             [EMAIL PROTECTED]
Operating system: Linux 2.4.6 Slackware
PHP version:      4.0.6
PHP Bug Type:     Unknown/Other Function
Bug description:  ext/standard/string.c patch for nl2br()

I suggest the following patch for string.c to fix the 
nl2br() function.

Instead of replacing "\n" with "<br />\n", I think 
"\n<br>" is better.  For example, in a string, there might 
be a "\r\n" and when nl2br() is applied, it would become 
"\r<br />\n".  Having a "\r" by itself and not paired with 
a "\n" causes problems for me because most programs afaik 
expect either just a "\n" (unix systems) or "\r\n" 
(microsoft systems) and know how to deal with them.  But 
when a "\r" is by itself, strange things sometimes happen 
and the file will print corrupted.  But applying the patch 
below, "\r\n" would become "\r\n<br>" which keeps the 
carriage return and newline pair intact and adds the 
break... unix and windows programs understand the file 
still and html renderers don't care about formatting.

*** string.c.orig       Thu Jul  5 08:41:46 2001
--- string.c    Thu Jul  5 08:38:04 2001
*** 2511,2517 ****


  /* }}} */

--- 2511,2517 ----


  /* }}} */

Edit Bug report at:

PHP Development Mailing List <>
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
To contact the list administrators, e-mail: [EMAIL PROTECTED]

Reply via email to