version_compare() with two args returns -1 / 0 / 1 today, if you want to
use it that way please do. I think the third arg is useful, and it's
not exactly bothering people who don't need it. I consider this
discussion as closed.
(Just for the record: version_compare is the only function now,
version_lt & friends are gone.)
- Stig
Jeroen van Wolffelaar wrote:
>
> Resent. The discussion isn't closed yet, and this is important, since it
> will be already in 4.1.0
>
> --Jeroen
> ----- Original Message -----
> From: "Jeroen van Wolffelaar" <[EMAIL PROTECTED]>
> To: "Andi Gutmans" <[EMAIL PROTECTED]>
> Cc: "PHP cvs" <[EMAIL PROTECTED]>
> Sent: Wednesday, October 10, 2001 8:46 PM
> Subject: Re: [PHP-CVS] cvs: php4 /ext/standard basic_functions.c
>
> > > Stig,
> > >
> > > Can we please keep these function names consistent with the PHP way and
> > not
> > > with Perl? We decided a long time ago to use significant function names,
> > > i.e., version_equals(). Also, do we really need all of those?
> >
> > Why not simply return -1, 0, 1, just like any comparator?
> >
> > The idea of 'comparator' is already in PHP in some places. Then you don't
> > have an additional parameter, and only 1 function.
> >
> > version_compare() would be the best name then.
> >
> > --Jeroen
> >
> > >
> > > Andi
> > >
> > > At 10:32 AM 10/10/2001 +0000, Stig Bakken wrote:
> > > >ssb Wed Oct 10 06:32:17 2001 EDT
> > > >
> > > > Modified files:
> > > > /php4/ext/standard basic_functions.c
> > > > Log:
> > > > * added function entries for version_{lt,le,gt,ge,eq}
> > > >
> > > >
> > > >Index: php4/ext/standard/basic_functions.c
> > > >diff -u php4/ext/standard/basic_functions.c:1.405
> > > >php4/ext/standard/basic_functions.c:1.406
> > > >--- php4/ext/standard/basic_functions.c:1.405 Sun Oct 7 14:34:44
> 2001
> > > >+++ php4/ext/standard/basic_functions.c Wed Oct 10 06:32:16 2001
> > > >@@ -17,7 +17,7 @@
> > > >
> > +----------------------------------------------------------------------+
> > > > */
> > > >
> > > >-/* $Id: basic_functions.c,v 1.405 2001/10/07 18:34:44 derick Exp $ */
> > > >+/* $Id: basic_functions.c,v 1.406 2001/10/10 10:32:16 ssb Exp $ */
> > > >
> > > > #include "php.h"
> > > > #include "php_main.h"
> > > >@@ -792,6 +792,11 @@
> > > >
> > > > /* functions from versioning.c */
> > > > PHP_FE(version_compare,
> > > > NULL)
> > > >+ PHP_FE(version_lt,
> > > > NULL)
> > > >+ PHP_FE(version_le,
> > > > NULL)
> > > >+ PHP_FE(version_gt,
> > > > NULL)
> > > >+ PHP_FE(version_ge,
> > > > NULL)
> > > >+ PHP_FE(version_eq,
> > > > NULL)
> > > >
> > > > {NULL, NULL, NULL}
> > > > };
> > > >
> > > >
> > > >
> > > >--
> > > >PHP CVS Mailing List (http://www.php.net/)
> > > >To unsubscribe, e-mail: [EMAIL PROTECTED]
> > > >For additional commands, e-mail: [EMAIL PROTECTED]
> > > >To contact the list administrators, e-mail:
> [EMAIL PROTECTED]
> > >
> >
>
> --
> PHP Development Mailing List <http://www.php.net/>
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
> To contact the list administrators, e-mail: [EMAIL PROTECTED]
--
PHP Development Mailing List <http://www.php.net/>
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
To contact the list administrators, e-mail: [EMAIL PROTECTED]
