> The problem is backward compatiblity.  That is the biggest thing at stake
> here.  Daniel and I are a bit skewed as we have over 1000 files full of
code
> that start with something like:
>
> if(defined("_FILE_NAME")) return;
> define("_FILE_NAME", 1);
>
> This was our solution _before_ include_once ever existed to keep files
from
> being included more than once.  We now know that it is in fact just not
> executed.

I was not aware of this.

> Our hope is to keep the old behaviour in tact for these cases where it is
a
> valid solution.  The patch I sent will now allow a function to be
redeclared
> ever, and it will raise an ERROR if the function is being declared in a
> different location than it has alread been encountered.

Did you measure the performance impact of your patch? If it does not slow
the engine significantly, then including it makes perfect sense. How does it
handle case described in bug #9884?

Edin


-- 
PHP Development Mailing List <http://www.php.net/>
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
To contact the list administrators, e-mail: [EMAIL PROTECTED]

Reply via email to