Hi Rasmus, today i woke up and i think the solution is to have read_exif_data a third parameter whether or not to return information if no exif is present. And to support TIFFs with GetImageSize we only need a small addition of say less than 100 lines c code...
marcus -------------------------------------- [sorry first one has gone to wrong mailing list - so here again] Hi Rasmus, i think Serge is correct because one can use standard functions for FileName,FileDateTime and FileSize. So better reply with false. The other solution would be adding an array entry 'EXIFPresent' (true|false) BUT i think that is not so good. From my point of view i would like to discuss the difference between getimagesize and read_exif_data a little: We would need some function*ality* from exif.c in image.c to support TIFF. When we have those functions we would be able to interpret APP markers of JPEG also (see below). I suppose we check whether or not ext/exif is present and then return read_exif_data results in GetImageSize (i do not see the point of returning and APP marker section which has to be interpreted). Then we should also make ext/exif default to present and change switch from --enable-exif to --disable-exif (prefer this). Or we move the necessary functions from exif.c to image.c and then make ext/exif optional for editing exif headers in the future. If to many people use APP return info we could use a third parameter to return interpreted values. The real point here is that i do not know what APP markers and EXIF headers have to do with GetImageSize but we have the information when adding TIFF support. what do you think? marcus ----------------------------------------------------------------------------------------------------------- #6787 [17 Sep 2000 6:07am] [EMAIL PROTECTED] Hi Guys, It seems that read_exif_data builds certain fields like FileName, FileDateTime, FileSize etc .. even when no real EXIF data exists. So read_exif_data will always return something....! This makes it a pain to test for the presence of actual EXIF data cause I have to do something like this: $exif_data = @read_exif_data($upload); if (isset ($exif_data['CameraMake'])) { Not very bullet proof .... Would be nice if it would not return anything without the presence of actual EXIF data. Thanks, Serge #14994 [11 Jan 6:07am] [EMAIL PROTECTED] I know, that Rasmus made the implementation for this function and that he used the header readouts from an imageinfo.c, but I'm missing the ability to identify TIFF images. As i'm not firm with imageheaders, I'd like to ask someone to implement this feature. -- PHP Development Mailing List <http://www.php.net/> To unsubscribe, visit: http://www.php.net/unsub.php