On Tue, Mar 19, 2002 at 01:30:22PM +0200, Jani Taskinen wrote:
> Does this attached patch fix it?
> (nice to have the checks in one place :)
Yes, everything is now working fine. Please go ahead and commit
the changes, and thanks for you quick reply.
> >The latest iconv detection code doesn't appear to account for the
> >case where iconv_open() is defined in libiconv. It only checks
> >for iconv_open() in libc and libiconv_open() in libiconv.
> >
> >This breaks the build under FreeBSD unless the GNU libiconv port
> >is installed.
> >
> >
>
> Index: acinclude.m4
> ===================================================================
> RCS file: /repository/php4/acinclude.m4,v
> retrieving revision 1.164
> diff -u -u -r1.164 acinclude.m4
> --- acinclude.m4 17 Mar 2002 21:09:20 -0000 1.164
> +++ acinclude.m4 19 Mar 2002 11:27:38 -0000
> @@ -1347,7 +1347,7 @@
> AC_DEFUN(PHP_SETUP_ICONV, [
> found_iconv=no
>
> - AC_CHECK_LIB(c, iconv_open, [
> + AC_CHECK_FUNCS(iconv libiconv, [
> AC_DEFINE(HAVE_ICONV, 1, [ ])
> found_iconv=yes
> ], [
> @@ -1370,7 +1370,7 @@
> if test -f $ICONV_DIR/lib/lib${iconv_lib_name}.a ||
> test -f $ICONV_DIR/lib/lib${iconv_lib_name}.$SHLIB_SUFFIX_NAME
> then
> - PHP_CHECK_LIBRARY($iconv_lib_name, libiconv_open, [
> + PHP_CHECK_LIBRARY($iconv_lib_name, libiconv, [
> found_iconv=yes
> PHP_ADD_LIBRARY_WITH_PATH($iconv_lib_name, $ICONV_DIR/lib, $1)
> AC_DEFINE(HAVE_ICONV, 1, [ ])
--
Jon Parise ([EMAIL PROTECTED]) . Information Technology (2001)
http://www.csh.rit.edu/~jon/ : Computer Science House Member
--
PHP Development Mailing List <http://www.php.net/>
To unsubscribe, visit: http://www.php.net/unsub.php
