Hello, is there something broken in the release branch too?
Derick On Wed, 27 Mar 2002, Marcus Börger wrote: > So one problem is my last 'fix' : i commited the older version ***sorry on > that*** > before realising that one of its reasons was wrong (See Kristians mail > http://lists.php.net/article.php?group=php.dev&article=81817): > > The file must start like this: > #!/usr/bin/php -f > and not > #!/usr/bin/php -- > > cvs -z3 -q diff php_cli.c (in directory S:\php4\sapi\cli\) > Index: php_cli.c > =================================================================== > RCS file: /repository/php4/sapi/cli/php_cli.c,v > retrieving revision 1.16 > diff -u -r1.16 php_cli.c > --- php_cli.c 26 Mar 2002 14:43:57 -0000 1.16 > +++ php_cli.c 27 Mar 2002 14:17:02 -0000 > @@ -554,7 +554,7 @@ > CG(interactive) = interactive; > > /* only set script_file if not set already and not in > direct mode and not at end of parameter list */ > - if (argc > ap_php_optind && !script_file && > behavior!=PHP_MODE_CLI_DIRECT && !strcmp(argv[ap_php_optind-1],"--")) { > + if (argc > ap_php_optind && !script_file && > behavior!=PHP_MODE_CLI_DIRECT && strcmp(argv[ap_php_optind-1],"--")) { > no_headers = 1; > script_file=argv[ap_php_optind]; > ap_php_optind++; > > I can now do testing: > > ./sapi/cli/php -d safe_mode=Off -f run-tests.php > > Because of the -d i suggest we add another overwrite to cli > > zend_alter_ini_entry("safe_mode", 10, "0", 1, PHP_INI_SYSTEM, > PHP_INI_STAGE_ACTIVATE); > > marcus > > TO WEZ: could you please verify then i will commit it. > > My results: > > TEST RESULT SUMMARY > ============================= > Number of tests: 222 > Tests skipped: 5 (2.3%) > Tests failed: 105 ( 48%) > Tests passed: 112 ( 52%) > ============================= > > Problems for me: > +files not found > +Warning - SAFE MODE Restriction in effect. > +databases all fail > > At 14:39 27.03.2002, you wrote: > >Actually, I'm getting a bit tired of things breaking so much recently; > >(the multiple function declaration in class thing and now this cli thing) > >can people checking code into CVS try to make sure that it compiles and > >that "make test" runs without too much trouble? It really is there for > >a purpose. > > > >Doesn't it say this in the CVS rules? > > > >I know that HEAD is a moving target, but there is no need to make > >things more difficult than they need to be. > > > >Just my 2-pence worth. > > > >--Wez. > > > > > > > >On 27/03/02, "Wez Furlong" <[EMAIL PROTECTED]> wrote: > > > Rolling back to php_cli.c revision 1.10 fixes this for me. > > > > "make test" does not work for me anymore. > > > > It seems that "./sapi/cli/php run-tests.php" goes into an infinite > > wait while > > > > parsing the script, whereas "./sapi/cli/php < run-tests.php" will > > run, but > > > > none of the tests will succeed. > > > > > > > >-- > >PHP Development Mailing List <http://www.php.net/> > >To unsubscribe, visit: http://www.php.net/unsub.php > ----------------------------------------------------------------------- PHP: Scripting the Web - [EMAIL PROTECTED] All your branches are belong to me! SRM: Script Running Machine - www.vl-srm.net ----------------------------------------------------------------------- -- PHP Development Mailing List <http://www.php.net/> To unsubscribe, visit: http://www.php.net/unsub.php
