No reason that I can think of. Changing the signature is fine by me. - Stig
On Fri, 2002-04-05 at 11:02, Zeev Suraski wrote: > Any particular reason not to just change the signature of > php_deflate_string()? Do you think anything else uses this function? I > doubt it, especially considering its not marked as an API function... > Otherwise, it sounds good... > > Zeev > > At 11:58 AM 4/5/2002, Stig S. Bakken wrote: > >Hi, > > > >I need to be able to specify the compression level in > >zlib.output_handler. I was planning to implement it like this: > > > >* add php_deflate_string2 (or php_deflate_string_ex) that lets you > >specify compression level, move the code from php_deflate_string into > >php_deflate_string2 and make php_deflate_string a wrapper. > > > >* add an output_compression_level module global and > >zlib.output_compression_level ini entry, defaulting to > >Z_DEFAULT_COMPRESSION > > > >* use php_deflate_string2 in php_gzip_output_handler > > > >* set zlib module version to "1.1" > > > >Comment/object now, or forever hold your piece, uhm, peace. > > > > - Stig > > > > > >-- > >PHP Development Mailing List <http://www.php.net/> > >To unsubscribe, visit: http://www.php.net/unsub.php -- PHP Development Mailing List <http://www.php.net/> To unsubscribe, visit: http://www.php.net/unsub.php
