On Fri, 28 Jun 2002, Justin Erenkrantz wrote:

> This syncs up with a recent API change to httpd-2.0 and will get
> apache2filter building again.  I'm not sure what PHP's policy is
> on backwards-compatibility with older httpd-2.0 releases, so I'll
> leave out the MMN check.

THis patch breaks building with earlier apache 2 versions anyway, so I 
don't see why the MMN check (whatever that may be) should not be in.

This patch was already committed to CVS a few days ago.

Derick

> 
> I will try to work on a more complete fix for PHP this weekend
> as it is susceptable to the same invalid 304 problem mod_include
> was.  (Just create a simple filter_init function that always sets
> r->no_local_copy to 1.)  -- justin
> 
> Index: sapi/apache2filter/sapi_apache2.c
> ===================================================================
> RCS file: /repository/php4/sapi/apache2filter/sapi_apache2.c,v
> retrieving revision 1.80
> diff -u -r1.80 sapi_apache2.c
> --- sapi/apache2filter/sapi_apache2.c 24 Jun 2002 16:04:20 -0000      1.80
> +++ sapi/apache2filter/sapi_apache2.c 28 Jun 2002 08:41:23 -0000
> @@ -564,8 +564,8 @@
>       ap_hook_post_config(php_apache_server_startup, NULL, NULL, APR_HOOK_MIDDLE);
>       ap_hook_insert_filter(php_insert_filter, NULL, NULL, APR_HOOK_MIDDLE);
>       ap_hook_post_read_request(php_post_read_request, NULL, NULL, APR_HOOK_MIDDLE);
> -     ap_register_output_filter("PHP", php_output_filter, AP_FTYPE_RESOURCE);
> -     ap_register_input_filter("PHP", php_input_filter, AP_FTYPE_RESOURCE);
> +     ap_register_output_filter("PHP", php_output_filter, NULL, AP_FTYPE_RESOURCE);
> +     ap_register_input_filter("PHP", php_input_filter, NULL, AP_FTYPE_RESOURCE);
>  }
>  
>  AP_MODULE_DECLARE_DATA module php4_module = {
> 
> -- 
> PHP Development Mailing List <http://www.php.net/>
> To unsubscribe, visit: http://www.php.net/unsub.php
> 

---------------------------------------------------------------------------
 Did I help you?   http://www.derickrethans.nl/link.php?url=giftlist
 Frequent ranting: http://www.derickrethans.nl/
---------------------------------------------------------------------------
                 PHP: Scripting the Web - [EMAIL PROTECTED]
                    All your branches are belong to me!
                SRM: Script Running Machine - www.vl-srm.net
---------------------------------------------------------------------------


-- 
PHP Development Mailing List <http://www.php.net/>
To unsubscribe, visit: http://www.php.net/unsub.php

Reply via email to