Hello, Chasing some ghosts in the variable receiving code (bug #16985) showed that there are some piece of code that exist twice in PHP (once in the normal stuff in php_variables.c, and once in mbstring.c). Because I do not like duplicate code, because it's hard to maintain and hard to debug (ask Edin :) I am in favor of dropping the normal stuff and just always use the multi byte version. What do you guys think of this?
Derick On Sun, 14 Jul 2002, Jani Taskinen wrote: > sniper Sat Jul 13 20:12:13 2002 EDT > > Modified files: > /php4/ext/mbstring config.m4 > Log: > These options are all enabled by default. (why?) > > > Index: php4/ext/mbstring/config.m4 > diff -u php4/ext/mbstring/config.m4:1.17 php4/ext/mbstring/config.m4:1.18 > --- php4/ext/mbstring/config.m4:1.17 Sat Jul 13 20:11:44 2002 > +++ php4/ext/mbstring/config.m4 Sat Jul 13 20:12:13 2002 > @@ -1,12 +1,12 @@ > dnl > -dnl $Id: config.m4,v 1.17 2002/07/14 00:11:44 sniper Exp $ > +dnl $Id: config.m4,v 1.18 2002/07/14 00:12:13 sniper Exp $ > dnl > > PHP_ARG_ENABLE(mbstr_enc_trans, whether to enable encoding translation, > -[ --disable-mbstr-enc-trans Enable encoding translation], yes) > +[ --disable-mbstr-enc-trans Disable encoding translation], yes) > > PHP_ARG_ENABLE(mbregex, whether to enable multibyte regex support, > -[ --disable-mbregex Enable multibyte regex support], yes) > +[ --disable-mbregex Disable multibyte regex support], yes) > > PHP_ARG_ENABLE(mbstring, whether to enable multibyte string support, > [ --disable-mbstring Disable multibyte string support], yes) > > > > -- > PHP CVS Mailing List (http://www.php.net/) > To unsubscribe, visit: http://www.php.net/unsub.php > --------------------------------------------------------------------------- Did I help you? http://www.derickrethans.nl/link.php?url=giftlist Frequent ranting: http://www.derickrethans.nl/ --------------------------------------------------------------------------- PHP: Scripting the Web - [EMAIL PROTECTED] All your branches are belong to me! SRM: Script Running Machine - www.vl-srm.net --------------------------------------------------------------------------- -- PHP Development Mailing List <http://www.php.net/> To unsubscribe, visit: http://www.php.net/unsub.php
