Well, the problem with doing it on a branch, the way I did, and as Lukas found out, is that it goes rather stale after a while. So I guess that I am actually proposing putting it in HEAD but #ifdef'ed out and perhaps not even providing a user-visible config option for it yet. You'd need to set a CFLAGS -DHOOKS=1 to activate it for now.
-Rasmus On Mon, 26 Aug 2002, George Schlossnagle wrote: > I wasn't proposing putting it in HEAD, just that the work was done > against HEAD not against your apache_hooks. Lukas redid all the > php<->apache request object work fresh off of head, and I made changes > off of that, so it contains nothing from your apache_hooks branch. > > Rasmus Lerdorf wrote: > > >I think if we put this in 4.3 we are going to delay 4.3 even further. > >Although, I suppose if we are careful and make sure we #ifdef it nicely > >and only turn it on with a configure option, we can put it in HEAD. > > > >So, is your patch my apache_hooks stuff + Lukas's work and then your stuff > >on top? > > > >On Mon, 26 Aug 2002, George Schlossnagle wrote: > > > >>All of this work was off HEAD. Should a new_apache_hooks branch be tagged? > >> > >>Rasmus Lerdorf wrote: > >> > >>>I say commit it. This stuff is very experimental as it is and lives in > >>>its own branch. You are not going to destabilize anything. > >>> > >>>(I just made sure you had enough karma for the commit) > >>> > >>>-Rasmus > >>> > >> > > > > > > > -- PHP Development Mailing List <http://www.php.net/> To unsubscribe, visit: http://www.php.net/unsub.php
