At 14:35 11.09.2002, Alan Knowles wrote: >I know it's a bit of a radical suggestion, but would depreciating >highlight_string in favour of a pear package using the tokenizer not be a >better approach. > >is there any reason to keep this in C?
Highliting is a feature from the parser and the php function is only a wrapper for the C functions used to implement that. Makes +1 from me for the modifucation and of cause for NOT removing it. >Anyway, just throwing a few stones into the water > >Regards >Alan > > > >Devon O'Dell wrote: > >>Hey, >> >>I don't know if this has been brought up before (you can smack me, I know >>that's the 3rd time I've said this), but something I (and others) thought >>would be cool is line numbering for highlight_file (aka show_source). >> >>I've made modifications so that this feature is settable from php.ini >>(highlight.format, either 0 or 1) and tested my source, looks like it >>works fine and the only stuff that didn't work in make test was stuff >>where the EXPECT was wrong. >> >>I guess I'm waiting for karma, lemme know if I should submit the patches >>in another email. >> >>Devon >> > > > > >-- >PHP Development Mailing List <http://www.php.net/> >To unsubscribe, visit: http://www.php.net/unsub.php -- PHP Development Mailing List <http://www.php.net/> To unsubscribe, visit: http://www.php.net/unsub.php
