[EMAIL PROTECTED] wrote:
> Yasuo,
>
> phps works fine, removing it would make people very angry (including
> me). It may not work for you, then simply don't use it.
I don't use it.
With php.ini-recommended, php _crashes_ when phps is used.
What kind of configuration you are using if php.ini-recommended
works for you.
I'm gussing this is due to how buffer is used and how
things are sent from PHP. Resolving this issue may require
inter dependency between php4 and Zend source. Zend source
should not depend on php4 soruce. I don't remeber details,
so it may be resolvable. Even if this can be resolved,
encoding issue remains.
IMHO, feature cannot be working right shouldn't be encouraged
using it, especially when there is good solution. This little
script does the job perfectly.
<?php
show_source(ereg_replace('phps$', 'php', $_SERVER['PATH_TRANSLATED']));
?>
> Also, Dan's patch looks fine, ofcourse there are always some little
> things with patches, but that doesn't matter right now.
>
It would be ok if it's a new flag is added to highlighe_string().
I'm not against for it. Let's add flag to the function.
--
Yasuo Ohgaki
> Derick
>
>
> On Thu, 19 Sep 2002, Yasuo Ohgaki wrote:
>
>
>>Dan Hardiker wrote:
>>
>>>Hi All,
>>>
>>>[all references to .phps are inheriently references to the modified
>>>highlight_file function, which in essence is the same thing]
>>>
>>>To prevent this getting blown out of all proportion (as so many things to
>>>where differences of opinion hit), can anyone with a view on this matter
>>>answer the following questions for me:
>>>
>>> 1. Does adding the ?HIGHLIGHT_FORMAT switch to the .phps file format
>>>reduce or degregate current / existing functionality in any way? {if yes,
>>>please expand)
>>
>>-1 for adding/chainging feature that is not working well.
>>Fix the issue before adding not required feature. I doubt there is
>>feasible solution, that's the reason why I against for it.
>>
>>Dan, you should use both php.ini-recommended and php.ini-dist. Or
>>search bug db. BTW, there should be other issues related to it.
>>
>>
>>>Bear in mind that no configuration changes are requried either in the
>>>php.ini, httpd.conf or anywhere. It is just an extension of functionality
>>>to the phps format.
>>>
>>> 2. Would the PHP community benifit from this extended functionality? (as
>>>a whole - Im not looking for a "well I wouldnt use it so -1")
>>
>>Line number would be useful. There was no discussion about usefulness,
>>AFAIK.
>>
>>
>>> 3. Are we looking to encourage or discourage active PHP development - or
>>>are we trying to slash down up-and-coming developers because of biest
>>>opinions and (perhaps) closed minded views?
>>
>>I'll discourage to develop and extend thing that will not work well.
>>
>>
>>>Although the .phps file isnt perfect, it cant do everything - neither is
>>>the rest of PHP, and nor should that stop development to try and improve
>>>it.
>>
>>Adding option for highlight_file() would be good enough.
>>(I'm not discouraging resolving phps related issues)
>>
>>
>>> 4. Is there any *good* reason why this patch should not be included? That
>>>is to ask, what negative effects does this script have.
>>>
>>>Personally I would like to see PHP extended and new developers are being
>>>welcomed in all the time. Constructive critisim is needed here guys, not
>>>just "I dont think thats good".
>>>
>>
>>I'm not against for having line number. -1 for changing not working
>>(obsolete, borken, half working, may not work, your favorite here) phps
>>feature. It's not needed. I even vote for removing it from php.
>>
>>Guys. Can you wirte something like this script with in a minuite?
>><?php
>>show_source(ereg_replace('phps$', 'php', $_SERVER['PATH_TRANSLATED']));
>>?>
>>
>>ln -s show_source.php target.phps
>>is no more complex than
>>ln -s target.php target.phps
>>
>>I guess all of know well, but don't forget change your web
>>server setting so that phps is parsed and executed by php.
>>
>>--
>>Yasuo Ohgaki
>>
>>
>>
>>
>>--
>>PHP Development Mailing List <http://www.php.net/>
>>To unsubscribe, visit: http://www.php.net/unsub.php
>>
>
>
> ---------------------------------------------------------------------------
> Derick Rethans http://derickrethans.nl/
> JDI Media Solutions
> -----------------------------[ [EMAIL PROTECTED]: Databases are for Assholes ]-
>
>
>
--
PHP Development Mailing List <http://www.php.net/>
To unsubscribe, visit: http://www.php.net/unsub.php
