Thanks for the patch :-) Aside from the signature change for openssl_pkcs7_verify (add the new args to the end of the proto), it looks ok to be merged for 4.3.
I know that openssl.c isn't the best example of the coding standards (and that this is largely due to me!), but please try and stick to the them (see the readme in the root of the php source); there are still some spaces where there should be tabs, but the main thing that I dislike is: <tab>foo=bar; should be <tab>foo = bar; Also, when submitting a patch, it's a courtesy to the maintainer of the extension to Cc the patch directly to them. Otherwise, you might find that you don't get any response for a while because the maintainer is buried alive in deadlines and email :-)) (you can find details about maintainers in the not very visible EXTENSIONS file in the php root, and details on supplying patches in the README.SUBMITTING_PATCH file). I don't want to sound pedantic about this, but you mentioned that you submitted this 2 months ago; I don't recall seeing it, and can't find your mail in my email archives - if it had been addressed directly to me then it would have been noticed and dealt with sooner. Anyway, thanks again for the patch; if you could fix the whitespace and make that function backwards compatible, I will merge it into the tree. --Wez. On 09/19/02, "Wojtek Slusarczyk" <[EMAIL PROTECTED]> wrote: > CVS version is php-cvs-openssl.diff.gz -- PHP Development Mailing List <http://www.php.net/> To unsubscribe, visit: http://www.php.net/unsub.php
