At 12:48 03/10/2002, Yasuo Ohgaki wrote: >Zeev Suraski wrote: >>But it does not seem as if you fixed it properly. I don't see how >>implicit flush can be at all related to output buffering. If it was, it >>should have been trivial to fix it, at a centralized place. You appear >>to be adding code all over the codebase, and as far as I understood from >>the thread, apparently you also made implicit flush disable output >>buffers, which is completely undesired behavior. Please revert! If >>there's still an issue with implicit flush after you revert, I will fix it. > >Zeev, > >ob_implicit_flush() and php.ini's implicit_flush never worked for >nested output buffers. > >Why? Older (which is very older now) code before my fix, >ob_implicit_flush() and implicit_flush was assuming there is >only one buffer always. It caused all kinds of problems due >to broken memory. > >Now, ppl is complaining w/o knowing how implicit flush and output >buffer is working. (which I think very rude) > >For others, > >implicit_flush in php.ini only for debugging. >It may do something unwanted thing in your script, but >this is original design.
As the one who introduced implicit_flush, no, it is not the original design at all. It's not something for debugging only, but also useful in certain interactive or report applications, including in the web environment. Again, Yasuo, I'm not sure why implicit_flush was related in any way to output buffering. You say that it was somehow incompatible with multiple buffers, and I believe you, but fixing it in a way that ties it with output buffering is wrong, period. Looking at the old code it looks like the bug was actually introduced by me (I disabled output buffering start_implicit_flush(), for no good reason), but greatly expanded by your recent patches. It's time to completely decouple these two, instead of strengthening their coupling. Zeev -- PHP Development Mailing List <http://www.php.net/> To unsubscribe, visit: http://www.php.net/unsub.php
