I thought we discussed that any error/warning message MUST
cause a test to fail. If you look at the diffs you will see that. And
that we do not use logging but direct displaying for that.

And again when special tests fail because a warning is emitted
you should either use --INI-- to disable messages for that single
test only or even better you should use --EXPECTF-- to detect
the expected messages.

The other thing you removed is error_log: I do not think this should
be removed since the idea was to have all error related ini settings
beeing the same.

So what ever you do please enable one mechanism to display those
errors and warnings.

regards
marcus

At 19:48 28.10.2002, Ilia Alshanetsky wrote:
iliaa           Mon Oct 28 13:48:07 2002 EDT

  Modified files:
    /php4       run-tests.php
  Log:
  This patch addresses the bogus test failures due to error logging/reporting
  confusion.


Index: php4/run-tests.php
diff -u php4/run-tests.php:1.97 php4/run-tests.php:1.98
--- php4/run-tests.php:1.97     Mon Oct 28 13:21:09 2002
+++ php4/run-tests.php  Mon Oct 28 13:48:07 2002
@@ -490,11 +490,10 @@
                "open_basedir=",
                "disable_functions=",
                "error_reporting=2047",
-               "display_errors=1",
+               "display_errors=0",
                "log_errors=0",
                "html_errors=0",
                "track_errors=1",
-               "error_log=",
                "report_memleaks=1",
                "docref_root=/phpmanual/",
                "docref_ext=.html",



--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

--
PHP Development Mailing List <http://www.php.net/>
To unsubscribe, visit: http://www.php.net/unsub.php

Reply via email to