At 15:32 05.11.2002, Wez Furlong wrote:
Hi Marcus,
I'm assuming that it's a warning about result being uninitialized; if
that is the case, lets just initialize it to zero in it's declaration.
Yes. It did it there so that further warnings may arise.
The cleanup code in errexit: inspects the first byte of tmp_line before
attempting to use it; it might also be a good idea to initialize
tmp_line to "" in it's declaration.
Seems like. But will there be a warning in that case anyway?
--Wez.
On 11/05/02, "Marcus B?rger" <[EMAIL PROTECTED]> wrote:
> helly Tue Nov 5 06:17:45 2002 EDT
>
> Modified files:
> /php4/ext/standard ftp_fopen_wrapper.c
> Log:
> silence
> #when i get this code right tmp_line is not initialised, too.
> #Therefore php_stream_wrapper_log_error() will be called with
> #undefined value, will it?
>
>
> Index: php4/ext/standard/ftp_fopen_wrapper.c
> diff -u php4/ext/standard/ftp_fopen_wrapper.c:1.36
php4/ext/standard/ftp_fopen_wrapper.c:1.37
> --- php4/ext/standard/ftp_fopen_wrapper.c:1.36 Fri Oct 4
17:58:39 2002
> +++ php4/ext/standard/ftp_fopen_wrapper.c Tue Nov 5 06:17:45 2002
> @@ -17,7 +17,7 @@
> | Hartmut Holzgraefe
<[EMAIL PROTECTED]> |
>
+----------------------------------------------------------------------+
> */
> -/* $Id: ftp_fopen_wrapper.c,v 1.36 2002/10/04 21:58:39 sesser Exp $ */
> +/* $Id: ftp_fopen_wrapper.c,v 1.37 2002/11/05 11:17:45 helly Exp $ */
>
> #include "php.h"
> #include "php_globals.h"
> @@ -162,8 +162,10 @@
> resource->port = 21;
>
> stream = php_stream_sock_open_host(resource->host,
resource->port, SOCK_STREAM, NULL, 0);
> - if (stream == NULL)
> + if (stream == NULL) {
> + result = 0; /* silence */
> goto errexit;
> + }
>
> php_stream_context_set(stream, context);
> php_stream_notify_info(context, PHP_STREAM_NOTIFY_CONNECT, NULL, 0);
>
>
>
> --
> PHP CVS Mailing List (http://www.php.net/)
> To unsubscribe, visit: http://www.php.net/unsub.php
--
PHP Development Mailing List <http://www.php.net/>
To unsubscribe, visit: http://www.php.net/unsub.php
