On 8 Nov 2002, Timm Friebe wrote:

>On Thu, 2002-11-07 at 14:46, Andrei Zmievski wrote:
>> On Sat, 02 Nov 2002, Timm Friebe wrote:
>> > Round 2 - fight:-)
>> > 
>> > OK, I guess now I'm ready for committing my changes. I got PHP compiled
>> > and tested out the new functionality of my ext/sybase_ct changes against
>> > CVS from today.
>> > 
>> > Just to make sure I'm getting it all right: This is what I'd put in the
>> > commit message
>[...]
>> Can you compress this down to a couple of entries?
>
>Sorry, I committed it before you wrote your e-mail. I don't quite
>understand why this should be shorter, though. This sort of was a
>mega-patch... or is it generally better so write stuff like 

    Andrei meant the NEWS entry I guess..which is just fine.
    You just didn't add it. :)

>  Added new functions: sybase_unbuffered_query(), sybase_fetch_assoc(),
>  sybase_set_message_handler(), see docs (Timm)
>
>I personally think I'd rather like to see a somewhat verbose Changelog.
>If this isn't what is wanted, I'll try and keep it shorter for future
>commits.

    Again, entries that go to ChangeLog only can be as long as you want
    them to be. NEWS entries are different issue. But the one 
    you had there is fine. splitting that to seperate entries would
    be very hard to find/read.
    
    --Jani
    


-- 
PHP Development Mailing List <http://www.php.net/>
To unsubscribe, visit: http://www.php.net/unsub.php

Reply via email to