Have regenerated the diffs in unified format as well as fixed a minor bug in the JP2 support. I've put together a small page at
http://www.j2g.org/php-dev/ It contains the patch, test script and a couple of example images in both raw codestream and JP2 format. adamw ----- Original Message ----- From: "Marcus Börger" <[EMAIL PROTECTED]> To: "Adam Wright" <[EMAIL PROTECTED]> Cc: <[EMAIL PROTECTED]> Sent: Thursday, January 16, 2003 7:40 PM Subject: Re: [PHP-DEV] jpeg2000 in php 4.3 > At 13:50 16.01.2003, Adam Wright wrote: > >I've completed a short patch which cleans up the JPEG 2000 raw codestream > >support ("j2c", though I've renamed it jpeg2000 in the file for clarity) in > >getimagesize. It also adds JP2 support. I've put a context diff of it > >against 4.3.x-dev from this morning up at... > > I have just updated my HEAD version and did a few changes and it works > very well. > > >Small changes have been made to ext/standard/php_image.h with 99% of the > >work in ext/standard/image.c. I've tried to apply CODING_STANDARDS, but it's > >probable I've messed up somewhere so I'm happy to make any changes or > >regenerate the diffs in other formats. > > You did good coding and style (but we prefer unified diffs "diff -u"). > > >If this gets applied, it might be worth adding something like the following > >to the documentation. > > It will be but it is to be discussed if it will go into 4.3.1: I'd say yes > because > the note in the manual. > > >"Note that JPEG 2000 and JP2 are capable of having components with differing > >bit depths. In this case, the value for "bits" is the highest bit depth > >encountered. Also, JP2 files can contain multiple JPEG 2000 codestreams. In > >this case, getimagesize returns the values for the first codestream it > >encounters in the root of the file." > > Yes such a note may be useful. > > >Hope it's useful. > > > >adamw > >[EMAIL PROTECTED] > > > >PS - I looked around but couldn't find any patch submission guidelines. Is > >there a page people should read first? > > As said above diff -u is prefered. > > regards & thanks > marcus > > by the way:could you send me a 1 x 1 jp2 file, because i am not able to produce > one my self? > > > -- PHP Development Mailing List <http://www.php.net/> To unsubscribe, visit: http://www.php.net/unsub.php
