On 12/05/2016 12:03 PM, Jordi Boggiano wrote:
On 05/12/2016 17:55, Sara Golemon wrote:
I was initially on the "keep it on the same line" side, largely as
that's how I've been writing it since before 7.0 was released, but the
arguments on this thread have convinced me that as recommended styles
go, separate lines is better.
I am still not really sold as I have never seen declare(encoding)
being used and ticks' only use (AFAIK, and especially as far as I've
seen in the wild) was signals handling and that is not needed anymore
in 7.1+.
<?php declare(strict_types=1) is short and can't be missed. Long live
the one liner!
Cheers
I'd say the opposite: My brain is already trained to ignore the <?php
line as noise, so anything added to that line WOULD be missed.
We also need to bear in mind implementation needs. It's going to be
much easier for the spec definition to define "these things, with one
line between them" than "these things, with one line between them,
except in this case where it's inlined, or this case where there's no
blank line, or this case..." And it's going to be much, much easier for
linters and auto-formatters to handle, too, I'd imagine.
I don't have a strong feeling about whether the file docblock or the
declares should come first. But I do favor the status quo of "one line
between each set of things" as it's less complex to define, read, and
parse than the alternatives.
--Larry Garfield
--
You received this message because you are subscribed to the Google Groups "PHP
Framework Interoperability Group" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/php-fig/76d4eee4-9e46-7834-96d0-ac885ac072b6%40garfieldtech.com.
For more options, visit https://groups.google.com/d/optout.
